FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Ensure distributive constraints of restrictive instantiations of type parameters don't exist by weswigham · Pull Request #47091 · microsoft/TypeScript · GitHub

/ TypeScript Public

Ensure distributive constraints of restrictive instantiations of type parameters don't exist - #47091

Closed
Wesley Wigham (weswigham) wants to merge 1 commit into
microsoft:mainfrom
weswigham:distributive-constraint-of-restrictive-instances-shouldnt-exist
ConversationCommits (1)ChecksFiles changed
Closed

Ensure distributive constraints of restrictive instantiations of type parameters don't exist#47091
Wesley Wigham (weswigham) wants to merge 1 commit into
microsoft:mainfrom
weswigham:distributive-constraint-of-restrictive-instances-shouldnt-exist

Conversation

Wesley Wigham (weswigham) commented Dec 9, 2021

Copy link
Copy Markdown
Member

Since restrictive instantiations replace type parameter constraints with unknown, if we use them to calculate a distributive constraint, we produce very wrong results. So we try to see if we're looking at such an instantiation when calculating a distributive constraint now, and choose to not yield a constraint if that is the case.

Fixes #46761

TypeScript Bot (typescript-bot) added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Dec 9, 2021

Bruce Pascoe (fatcerberus) commented Dec 13, 2021

Copy link
Copy Markdown

What is a "restrictive instantiation"? #46761 doesn't mention that term, and I've personally never heard of it. Is it some kind of internal implementation detail?

Wesley Wigham (weswigham) commented Dec 13, 2021

Copy link
Copy Markdown
Member Author

It's definitely an implementation detail. It's part of how we check if no instantiation of one thing is assignable to another thing.

Nathan Shively-Sanders (sandersn) commented Feb 28, 2023

Copy link
Copy Markdown
Member

Wesley Wigham (@weswigham) I'm going through all the ready-to-merge PRs, and this one is signed off. Is it worth bringing up to date and merging it for 5.1?

Jake Bailey (jakebailey) commented Mar 2, 2023

Copy link
Copy Markdown
Member

Apparently the linked issue was fixed in #50397.

PR for just the test is here: #53067

Nathan Shively-Sanders (sandersn) commented Mar 3, 2023

Copy link
Copy Markdown
Member

All right, this is old and looks like it's obsolete, so I'm going to close it.

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Ryan Cavanaugh (RyanCavanaugh) RyanCavanaugh approved these changes
Nathan Shively-Sanders (sandersn) Awaiting requested review from sandersn
Anders Hejlsberg (ahejlsberg) Awaiting requested review from ahejlsberg

Assignees

Wesley Wigham (weswigham)

Labels

Author: Team For Milestone Bug PRs that fix a bug with a specific milestone

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Conditional type simplified too early

6 participants

Back | FazBrowse Home | New Git URL