Fix narrowing of intersection with function type - #47483
Merged
Gabriela Araujo Britto (gabritto) merged 2 commits intoJan 21, 2022
Merged
Fix narrowing of intersection with function type#47483Gabriela Araujo Britto (gabritto) merged 2 commits into
Gabriela Araujo Britto (gabritto) merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Gabriela Araujo Britto (gabritto)
requested review from
Anders Hejlsberg (ahejlsberg) and
Wesley Wigham (weswigham)
January 17, 2022 23:13
Ryan Cavanaugh (RyanCavanaugh)
approved these changes
Jan 19, 2022
Copy link
Copy Markdown
Member
|
TypeScript Bot (@typescript-bot) test this |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the extended test suite on this PR at e17ca56. You can monitor the build here. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the parallelized community code test suite on this PR at e17ca56. You can monitor the build here. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the perf test suite on this PR at e17ca56. You can monitor the build here. Update: The results are in! |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the parallelized Definitely Typed test suite on this PR at e17ca56. You can monitor the build here. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Daniel Rosenwasser (@DanielRosenwasser) Comparison Report - main..47483
System
Hosts
Scenarios
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I'm curious why you've included TypeFacts.TypeofEQObject and TypeFacts.TypeofNEObject in TypeFacts.OrFactsMask? I'd be inclined to think an intersection is an object only when every constituent is an object. Meaning the flags should be and-ed, not or-ed. For example: function test(x: number & { _foo: string }) {
if (typeof x === 'object') {
x; // Used to narrow to never, now doesn't
}
}It's fairly common to have tagged primitives like that, but they shouldn't appear to be objects. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I think TypeFacts.TypeofEQObject was a mistake on my part, given that behavior. But TypeofNEObject still makes sense to me to be an or mask because of the interaction between objects and functions: function f1(x: F & { foo: number }) {
if (typeof x !== "object") {
x; // Narrows to `never` if `TypeFacts.TypeofNEObject` is an `and` mask
}
}However, there's also a mistake on the ignoreObjects behavior: we should return the AndMask instead of falling back and returning All, since All is no longer the identity element for computing type facts of intersections. Made the fixes here: #47583 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
Assignees
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45801.
Second attempt at a fix, first is in #47282 (along with some explanation of the issue).