No contextual typing from return types for boolean literals - #48380
Merged
Anders Hejlsberg (ahejlsberg) merged 3 commits intoMar 30, 2022
Merged
No contextual typing from return types for boolean literals#48380Anders Hejlsberg (ahejlsberg) merged 3 commits into
Anders Hejlsberg (ahejlsberg) merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
TypeScript Bot (@typescript-bot) test this |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Heya Anders Hejlsberg (@ahejlsberg), I've started to run the parallelized Definitely Typed test suite on this PR at 08526c0. You can monitor the build here. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Heya Anders Hejlsberg (@ahejlsberg), I've started to run the abridged perf test suite on this PR at 08526c0. You can monitor the build here. Update: The results are in! |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Heya Anders Hejlsberg (@ahejlsberg), I've started to run the extended test suite on this PR at 08526c0. You can monitor the build here. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Heya Anders Hejlsberg (@ahejlsberg), I've started to run the diff-based community code test suite on this PR at 08526c0. You can monitor the build here. Update: The results are in! |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Anders Hejlsberg (@ahejlsberg) |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Anders Hejlsberg (@ahejlsberg) Comparison Report - main..48380
System
Hosts
Scenarios
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
All tests are clean and performance is unaffected. I think this one is good to merge. EDIT: Actually, a few changes in the extended test suite, but all to be expected. Three of the changes are errors that go away in immutable.js (foldLeft with a boolean literal seed). |
Sorry, something went wrong.
Anders Hejlsberg (ahejlsberg)
requested a review
from Ryan Cavanaugh (RyanCavanaugh)
March 23, 2022 14:11
Anders Hejlsberg (ahejlsberg)
requested a review
from Daniel Rosenwasser (DanielRosenwasser)
March 23, 2022 14:12
Ryan Cavanaugh (RyanCavanaugh)
approved these changes
Mar 30, 2022
Sidharth Vinod (sidharthv96)
added a commit
to sidharthv96/TypeScript
that referenced
this pull request
Apr 1, 2022
* upstream/main: (473 commits) Correct node used for isDefinition calculation (microsoft#48499) fix(48405): emit dummy members from a mapped type (microsoft#48481) CFA for dependent parameters typed by generic constraints (microsoft#48411) No contextual typing from return types for boolean literals (microsoft#48380) fix(47733): omit JSDoc comment template suggestion on node with existing JSDoc (microsoft#47748) Ensure that we copy empty NodeArrays during transform (microsoft#48490) Add a new compiler option `moduleSuffixes` to expand the node module resolver's search algorithm (microsoft#48189) feat(27615): Add missing member fix should work for type literals (microsoft#47212) Add label details to completion entry (microsoft#48429) Enable method signature completion for object literals (microsoft#48168) Fix string literal completions when a partially-typed string fixes inference to a type parameter (microsoft#48410) fix(48445): show errors on type-only import/export specifiers in JavaScript files (microsoft#48449) Fix newline inserted in empty block at end of formatting range (microsoft#48463) Prevent looking up symbol for as const from triggering an error (microsoft#48464) Revise accessor resolution logic and error reporting (microsoft#48459) fix(48166): skip checking module.exports in a truthiness call expression (microsoft#48337) LEGO: Merge pull request 48450 LEGO: Merge pull request 48436 fix(48031): show circularity error for self referential get accessor annotations (microsoft#48050) Revert "Fix contextual discrimination for omitted members (microsoft#43937)" (microsoft#48426) ...
This was referenced Jul 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a small change to contextual typing of boolean literals: When a boolean literal in a function argument expression is contextually typed by a type variable, and type boolean was inferred for that type variable through function return type inference, we remove boolean from the instantiated contextual type, thus causing the boolean literal to widen to type boolean (as it would had it not been contextually typed).
Fixes #48363.
Also fixes issue mentioned here.