Revert "feat(47595): allow using private fields in type queries" - #48959
Merged
Jake Bailey (jakebailey) merged 1 commit intoMay 4, 2022
Merged
Revert "feat(47595): allow using private fields in type queries"#48959Jake Bailey (jakebailey) merged 1 commit into
Jake Bailey (jakebailey) merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…osoft#47696)" This reverts commit 063eaa7.
Jake Bailey (jakebailey)
requested review from
Daniel Rosenwasser (DanielRosenwasser) and
Nathan Shively-Sanders (sandersn)
May 4, 2022 22:13
This was referenced May 4, 2022
Daniel Rosenwasser (DanielRosenwasser)
approved these changes
May 4, 2022
3 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopens #47595
This caused an accidental API break (noted here #47696 (comment)).
It's too close to 4.7 to come up with a redesigned AST, so reverting.