| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
…emove out as an option for project tests
This has a curious interaction with how ES6 implicitly has modules sometimes, and may require either a breaking change in our parser API or a breaking change in our tsconfig spec or a breaking change in our behavior regarding ES6 and modules. One of them, depending on what we'd rather do. I think that part of this, specifically, should probably be filed as a seperate bug, after looking into it. |
Sorry, something went wrong.
|
Ping Daniel Rosenwasser (@DanielRosenwasser) - I think this is complete as far as this PR is concerned. We'll need to file followup issues regarding implementation of Mohamed Hegazy (@mhegazy)'s change and how it interacts with --target es6. |
Sorry, something went wrong.
|
I would say let's get --module and --out working instead of disallowing it and then allowing it again. it is a breaking change either ways. |
Sorry, something went wrong.
|
as discussed offline, let's close this and support --module and --out combination. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
In #1544 this has been discussed for awhile. The changes to make the basics of it happen are easy, but the repercussions are fairly large for our own code. Our own compiler and projects tests in particular both used --out with --module. Changing the Jakefile to fix our compiler was easy, changes to our projects tests are also complete. Daniel Rosenwasser (@DanielRosenwasser) asked me to include this error in #4754, but it impacts our own infrastructure enough in a breaking-change kinda way that it warrants its own PR.