Don't elide imports when transforming JS files - #50404
Merged
Gabriela Araujo Britto (gabritto) merged 11 commits intoSep 19, 2022
Merged
Don't elide imports when transforming JS files#50404Gabriela Araujo Britto (gabritto) merged 11 commits into
Gabriela Araujo Britto (gabritto) merged 11 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Loading
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
Assignees
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #48588.
The fix, as discussed in the design meeting, is to never elide imports when transforming JS files.
Note that this breaks some assumptions that were being made by further transforms, such as looking up only value symbols when finding whether an identifier was an import.
Also note: this change is when transforming JS files only. And it only updates our transforms to not eliding imports. Exports in JS files will still be elided as before.