Flip imports to case insensitive sorting - #51579
Merged
Jake Bailey (jakebailey) merged 1 commit intoNov 17, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Jake Bailey (jakebailey)
requested review from
Andrew Branch (andrewbranch) and
Wesley Wigham (weswigham)
November 17, 2022 22:03
Wesley Wigham (weswigham)
approved these changes
Nov 17, 2022
Wesley Wigham (weswigham)
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
We should file 2 bugs:
- To fix auto imports insertion order on case-sensitive import lists
- To swap our imports back once we've shipped said fix
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
How much do we need 2? My only problem is just that it's more churn for other PRs again if I reorder everything. I suppose it's one time, but I don't know that it actually matters what the order is as long as it merges well (which any sort will do). |
Sorry, something went wrong.
This was referenced Nov 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After merging #51565, I went to merge it into SFT only to hit issues with auto-imports; it looks like auto-imports always inserts new imports at the bottom unless the imports are sorted case-insensitivly.
Flipping these imports to case insensitive means that future auto-imports seem to be inserted in the right place.