| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Wow, after multiple reruns, I think declarationEmitPrivatePromiseLikeInterface is literally too slow to finish on a Windows CI builder with Node 14. |
Sorry, something went wrong.
|
The above is hopefully better after #52382 (the PR saved a significant amount on that test). We'll see if it passes or if there's still more to find. |
Sorry, something went wrong.
|
Marking this as ready-for-review; it seems to be working with that performance bump from reused Printers. |
Sorry, something went wrong.
|
Oh, hm, it was actually macOS this last time that was slow. It's a minute or so faster now but not really in range of other machines. |
Sorry, something went wrong.
There was a problem hiding this comment.
We'd probably be fine with only testing all OSes on latest node, coverage-wise, but the full matrix is fine, since, y'know, it's not like we're getting billed, right? 😆 (...do we have a GHA max worker limit?)
Sorry, something went wrong.
We totally don't; Python's typeshed repo (equivalent to DT) runs 54 jobs per PR/commit. One reason I would be testing on the full matrix is that we've seen breaks like how Node upgraded its icu library and changed the output of Date.toLocaleTimeString(); that one happened to occur on Linux (so we caught it), but I think something like that is equally likely to happen on the other OSs too. |
Sorry, something went wrong.
|
Well, I guess "latest" would get us those breaks, yeah. But I don't think there's really a downside of testing everything. |
Sorry, something went wrong.
|
Rechecking, the timeout is 40s for any singular test; with that one expensive test everything else seems to run under that limit. I was worried because the macOS builder takes 20 minutes (as opposed to 10-15 for other OSs), but an overall long time isn't bad so long as each individual test can run. I was assuming there was a total-time timeout but nope. |
Sorry, something went wrong.
|
declarationEmitPrivatePromiseLikeInterface is still flaky, it seems. Will have to keep profiling it. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Up until now, we only tested Linux in CI. It seems like a good idea to test all of our supported platforms and versions (especially since we get it "for free" in parallel).