Don't error when calling resolveEntityName - #53441
Don't error when calling resolveEntityName#53441Gabriela Araujo Britto (gabritto) merged 3 commits into
Conversation
Sorry, something went wrong.
|
TypeScript Bot (@typescript-bot) user test this |
Sorry, something went wrong.
|
Heya Gabriela Araujo Britto (@gabritto), I've started to run the diff-based user code test suite on this PR at ed815a1. You can monitor the build here. Update: The results are in! |
Sorry, something went wrong.
|
Heya Gabriela Araujo Britto (@gabritto), I've started to run the parallelized Definitely Typed test suite on this PR at ed815a1. You can monitor the build here. Update: The results are in! |
Sorry, something went wrong.
|
Heya Gabriela Araujo Britto (@gabritto), I've started to run the diff-based top-repos suite on this PR at ed815a1. You can monitor the build here. Update: The results are in! |
Sorry, something went wrong.
|
|
||
| meaning |= SymbolFlags.Alias; | ||
| const entityNameSymbol = isEntityNameExpression(name) ? resolveEntityName(name, meaning) : undefined; | ||
| const entityNameSymbol = isEntityNameExpression(name) ? resolveEntityName(name, meaning, /*ignoreErrors*/ true) : undefined; |
There was a problem hiding this comment.
It's my understanding that we expect that this resolveEntityName call might fail, judging from the if statement below and the rest of the code (and an earlier resolve call that also ignores errors)`, so we shouldn't report errors here.
Sorry, something went wrong.
|
Gabriela Araujo Britto (@gabritto) Here are the results of running the user test suite comparing main and refs/pull/53441/merge: Everything looks good! |
Sorry, something went wrong.
| //// const x = Foo.makeFoo<{}>; //// Cannot find name 'Foo'.ts(2304) | ||
| //// //// 'Foo' only refers to a type, but | ||
| //// //// is being used as a namespace here.ts(2702) | ||
|
|
||
| //// x({}); // 👍 `const x: <{}>(context: {}) => <T>(value: T) => Foo<T, {}>` |
There was a problem hiding this comment.
I think the comments are helpful for the issue, but are confusing here for the test case.
Sorry, something went wrong.
|
getSymbolAtLocation is supposed to be language servicey. Unfortunately
least we can do is test for stability/speed in the language service. TypeScript Bot (@typescript-bot) user test tsserver |
Sorry, something went wrong.
|
Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the diff-based user code test suite (tsserver) on this PR at ed815a1. You can monitor the build here. Update: The results are in! |
Sorry, something went wrong.
|
Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the diff-based top-repos suite (tsserver) on this PR at ed815a1. You can monitor the build here. Update: The results are in! |
Sorry, something went wrong.
|
Daniel Rosenwasser (@DanielRosenwasser) Here are the results of running the user test suite comparing main and refs/pull/53441/merge: Everything looks good! |
Sorry, something went wrong.
|
Hey Gabriela Araujo Britto (@gabritto), the results of running the DT tests are ready. |
Sorry, something went wrong.
|
Gabriela Araujo Britto (@gabritto) Here are the results of running the top-repos suite comparing main and refs/pull/53441/merge: Everything looks good! |
Sorry, something went wrong.
|
Daniel Rosenwasser (@DanielRosenwasser) Here are the results of running the top-repos suite comparing main and refs/pull/53441/merge: Everything looks good! |
Sorry, something went wrong.
Fixes #53247.