Remove eslint-plugin-import - #54835
Merged
Jake Bailey (jakebailey) merged 2 commits intoJul 14, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Sheetal Nandi (sheetalkamat)
approved these changes
Jun 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use this plugin for only one rule, no-extraneous-dependencies, to verify that we don't import a package which isn't listed in our package.json.
In our repo, this plugin weighs in at 61 dependencies (out of 368, ~17%). Removing it speeds up npm ci by ~20%, and linting itself by roughly 2%.
I think there's a cost/benefit ratio when it comes to this kind of thing. TypeScript is notoriously dependency-free so I think we're going to already take heed when reviewing any PR which introduces any new import/require (which, hasn't happened in a long time), and we could revive it if this starts to not be true anymore.