Enable @typescript-eslint/ban-types - #55133
Merged
Jake Bailey (jakebailey) merged 3 commits intoJul 27, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
why isn’t Function treated as a top type similar to (...args: never) => unknown? |
Sorry, something went wrong.
Sheetal Nandi (sheetalkamat)
approved these changes
Jul 27, 2023
Copy link
Copy Markdown
Member
Author
Presumably exactly for the reason I gave; (...args: never) => unknown can't be new-d but Function can. But, I'm not a total expert on why. I definitely read something about this in the past year but it's hard to find when the only term I can use is "function". |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #54693.
All of the things it catches are harmless, realistically, though I agree that as Function was the wrong cast as that'd let us accidentally new it or something.
I definitely disagree with the default of banning {}; that's a very useful type (especially post #49119, a number I have memorized at this point). Annoyingly, violating the rule that bans {} or Object says to use NonNullable<unknown> which is exactly {}.
The fact that Symbol is mistaken as the global Symbol I believe is a bug in ts-eslint, though I don't think it's reported so I'll do that shortly. typescript-eslint/typescript-eslint#7306
Disabling those two leaves the rule to only ban the uppercase primitive wrapper types (good) and Object (probably good), so it seems like this rule is fine to keep enabled.