Triage and fix some eslint rules - #55136
Merged
Jake Bailey (jakebailey) merged 3 commits intoJul 24, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Jake Bailey (jakebailey)
requested review from
Nathan Shively-Sanders (sandersn) and
Sheetal Nandi (sheetalkamat)
July 24, 2023 18:56
Comment thread
.eslintrc.json
| "@typescript-eslint/no-namespace": "off", | ||
| "@typescript-eslint/no-non-null-asserted-optional-chain": "off", | ||
| "@typescript-eslint/no-var-requires": "off", | ||
| "@typescript-eslint/no-empty-interface": "off", |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
This one deserves an explanation; while it's definitely bad to have empty interfaces, we seem to have quite a few cases which are "valid" in that they do things like rebinding another interface with new type variables (many in types), providing an interface that is augmented elsewhere (SourceFile), and so on.
Sorry, something went wrong.
Nathan Shively-Sanders (sandersn)
approved these changes
Jul 24, 2023
Copy link
Copy Markdown
Member
Author
|
After #55137, I've also added no-extra-boolean-cast, which similarly is too strict to work. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #54693.
This PR triages the rules that should "obviously" be disabled or fixed.
This caught a case where I had not noticed a stray debugger line in a PR.