FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Make AssertEntry and AssertClause interfaces by andrewbranch · Pull Request #56485 · microsoft/TypeScript · GitHub

/ TypeScript Public

Make AssertEntry and AssertClause interfaces - #56485

Merged
Andrew Branch (andrewbranch) merged 1 commit into
mainfrom
bug/56477
Nov 21, 2023
ConversationCommits (1)ChecksFiles changed
Merged

Make AssertEntry and AssertClause interfaces#56485
Andrew Branch (andrewbranch) merged 1 commit into
mainfrom
bug/56477

Conversation

Andrew Branch (andrewbranch) commented Nov 21, 2023

Copy link
Copy Markdown
Member

Fixes #56477

TypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Nov 21, 2023

TypeScript Bot (typescript-bot) commented Nov 21, 2023

Copy link
Copy Markdown
Contributor

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure Daniel Rosenwasser (@DanielRosenwasser) and Ryan Cavanaugh (@RyanCavanaugh) are aware of the changes, just as a heads up.

Andrew Branch (andrewbranch) mentioned this pull request Nov 21, 2023
Merged

Bruce Pascoe (fatcerberus) commented Nov 21, 2023

Copy link
Copy Markdown

Ugh. I get that this is to fix a real-world break, but interface Foo extends Bar {} is just… yuck.

Andrew Branch (andrewbranch) commented Nov 21, 2023

Copy link
Copy Markdown
Member Author

Getting in the weeds with DefinitelyTyped has conditioned me to see interface Foo extends SomeInterface {} as beautiful and type Foo = SomeInterface as unsettling

Daniel Rosenwasser (DanielRosenwasser) approved these changes Nov 21, 2023
View reviewed changes

Daniel Rosenwasser (DanielRosenwasser) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

TIHI

Andrew Branch (andrewbranch) commented Nov 21, 2023

Copy link
Copy Markdown
Member Author

🤔

TypeScript Bot (typescript-bot) pushed a commit to typescript-bot/TypeScript that referenced this pull request Nov 21, 2023
Pick microsoft#56485 into release-5.3 (microsoft#56486)
f750eb3
Brad Zacher (bradzacher) mentioned this pull request Jan 4, 2024
Closed
4 tasks
Closed
6 tasks
Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Daniel Rosenwasser (DanielRosenwasser) DanielRosenwasser approved these changes
Jake Bailey (jakebailey) jakebailey approved these changes

Assignees

Andrew Branch (andrewbranch)

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[5.3] Deprecated types (AssertEntry, AssertClause) redefined as type aliases, rather than interfaces

5 participants

Back | FazBrowse Home | New Git URL