FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Transpile jsdoc parsing mode by sheetalkamat · Pull Request #56627 · microsoft/TypeScript · GitHub

/ TypeScript Public

Transpile jsdoc parsing mode - #56627

Merged
Sheetal Nandi (sheetalkamat) merged 3 commits into
mainfrom
transpileJSDoc
Dec 1, 2023
ConversationCommits (3)ChecksFiles changed
Merged

Transpile jsdoc parsing mode#56627
Sheetal Nandi (sheetalkamat) merged 3 commits into
mainfrom
transpileJSDoc

Conversation

Sheetal Nandi (sheetalkamat) commented Dec 1, 2023

Copy link
Copy Markdown
Member

Fixes #56625

TypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Dec 1, 2023

TypeScript Bot (typescript-bot) commented Dec 1, 2023

Copy link
Copy Markdown
Contributor

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure Daniel Rosenwasser (@DanielRosenwasser) and Ryan Cavanaugh (@RyanCavanaugh) are aware of the changes, just as a heads up.

Jake Bailey (jakebailey) reviewed Dec 1, 2023
View reviewed changes
Comment thread src/services/transpile.ts Outdated

Jake Bailey (jakebailey) commented Dec 1, 2023

Copy link
Copy Markdown
Member

I will be interested in a test for this; my impression was that this flag did not affect emit at all, and #56625 did not mention transformers in the original report.

Andrew Branch (andrewbranch) reviewed Dec 1, 2023
View reviewed changes
Comment thread src/services/transpile.ts Outdated
Sheetal Nandi (sheetalkamat) commented Dec 1, 2023
View reviewed changes
Comment thread src/services/transpile.ts Outdated

Andrew Branch (andrewbranch) commented Dec 1, 2023

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) cherry-pick this to release-5.3

TypeScript Bot (typescript-bot) commented Dec 1, 2023

Copy link
Copy Markdown
Contributor

Heya Andrew Branch (@andrewbranch), I've started to cherry-pick this into release-5.3 for you. Here's the link to my best guess at the log.

TypeScript Bot (typescript-bot) commented Dec 1, 2023

Copy link
Copy Markdown
Contributor

Hey Andrew Branch (@andrewbranch), I've created #56629 for you.

Merged
Sheetal Nandi (sheetalkamat) deleted the transpileJSDoc branch December 1, 2023 01:21
Daniel Rosenwasser (DanielRosenwasser) added a commit that referenced this pull request Dec 2, 2023
🤖 Pick PR #56627 (Transpile jsdoc parsing mode) into release-5.3 (#56629
4c2afa7 
)

Co-authored-by: Sheetal Nandi <shkamat@microsoft.com>
Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>
Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Jake Bailey (jakebailey) jakebailey left review comments
Andrew Branch (andrewbranch) andrewbranch approved these changes

Assignees

Sheetal Nandi (sheetalkamat)

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make JSDoc Parsing Configurable using the transpileModule method

4 participants

Back | FazBrowse Home | New Git URL