Extend isEmptyAnonymousObjectType with support for non-generic mapped types - #56974
Closed
Mateusz Burzyński (Andarist) wants to merge 2 commits into
Closed
Extend isEmptyAnonymousObjectType with support for non-generic mapped types#56974Mateusz Burzyński (Andarist) wants to merge 2 commits into
Mateusz Burzyński (Andarist) wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
src/compiler/checker.ts
| @@ -20849,7 +20849,11 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker { | |||
| } | |||
|
|
|||
| function isEmptyAnonymousObjectType(type: Type) { | |||
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Note that this is different from isEmptyObjectType and none of those reuse the other. Perhaps with this change, some sharing could be introduced. I tried that at first and a lot of tests failed - but I didn't bother digging into this right now.
I don't really know what's the intended use case of both. Some code comments here would be highly appreciated. I could add the. However, I'd need first to learn from the team about the different goals of those two.
Sorry, something went wrong.
| import { B, C, D } from './types2'; | ||
|
|
||
| export class C implements Base { | ||
| a: Readonly<A> & { kind: 'a'; }; |
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
This is a somewhat unfortunate change. However, it matches the behavior of plain A that is {}. In such a case, A doesn't appear in the output after the refactoring. Maybe that's an issue worth raising? The intention of the user could have been to reuse types from the interface quite literally - so when they start implementing A's members the C class automatically "receives" them.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I agree that it might be unfortunate, but I think this change is ok. If we want to have a mechanism for preserving those kinds of intersections in refactorings and codefixes, we need it to also work for A & { kind: ... }.
Sorry, something went wrong.
Comment thread
tests/cases/fourslash/completionPreferredSuggestions1.ts
Comment on lines
+18
to
+20
| verify.completions({ marker: "3", exact: [] }); | ||
| verify.completions({ marker: "4", exact: [] }); | ||
| verify.completions({ marker: "5", includes: ["a", "b", "c"] }); | ||
| verify.completions({ marker: "5", exact: [] }); |
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Since Record<never, never> is just {} with this PR those are expected here. Those unions were reduced to just string and thus concrete literal strings can no longer be suggested.
Both of those changed locations obey the rule from #49119 :
For backwards compatibility, special exceptions to the T & {} type reduction rules existing for intersections written explicitly as string & {}, number & {}, and bigint & {} (as opposed to created through instantiation of a generic type T & {}).
Sorry, something went wrong.
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
How is it that this string & Record<never, never> was being preserved before? Is it because, before this PR, Record<never, never> was some mapped type and we couldn't do subtype reduction on the intersection?
I'm curious to see if this breaks people, since this is in our tests, but you're right, officially we only support string & {} explicitly written as so.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Is it because, before this PR, Record<never, never> was some mapped type and we couldn't do subtype reduction on the intersection?
IIRC - yeah, something like that. The type was not reduced to {} so it stayed as a mapped type and that wasn't reduced. But with this change it's treated like {} so intersections containing it are way more easily reducible.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
TypeScript Bot (@typescript-bot) run DT |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Heya Gabriela Araujo Britto (@gabritto), I've started to run the parallelized Definitely Typed test suite on this PR at 081619e. You can monitor the build here. Update: The results are in! |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Heya Gabriela Araujo Britto (@gabritto), I've started to run the diff-based top-repos suite on this PR at 081619e. You can monitor the build here. Update: The results are in! |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Heya Gabriela Araujo Britto (@gabritto), I've started to run the diff-based user code test suite on this PR at 081619e. You can monitor the build here. Update: The results are in! |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Heya Gabriela Araujo Britto (@gabritto), I've started to run the regular perf test suite on this PR at 081619e. You can monitor the build here. Update: The results are in! |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Gabriela Araujo Britto (@gabritto) Here are the results of running the user test suite comparing main and refs/pull/56974/merge: There were infrastructure failures potentially unrelated to your change:
Otherwise... Something interesting changed - please have a look. Detailspuppeteerpackages/browsers/test/src/tsconfig.json
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Gabriela Araujo Britto (@gabritto)
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
tsserverComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
startupComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Hey Gabriela Araujo Britto (@gabritto), the results of running the DT tests are ready. Package: react-aria-live Error:
/home/vsts/work/1/DefinitelyTyped/types/react-aria-live/react-aria-live-tests.tsx
5:2 error TypeScript@local compile error:
No overload matches this call.
Overload 1 of 2, '(props: {} | Readonly<{}>): LiveAnnouncer', gave the following error.
Type '{ children: Element; }' has no properties in common with type 'IntrinsicAttributes & IntrinsicClassAttributes<LiveAnnouncer>'.
Overload 2 of 2, '(props: {}, context: any): LiveAnnouncer', gave the following error.
Type '{ children: Element; }' has no properties in common with type 'IntrinsicAttributes & IntrinsicClassAttributes<LiveAnnouncer>' @definitelytyped/expect
13:2 error TypeScript@local compile error:
No overload matches this call.
Overload 1 of 2, '(props: {} | Readonly<{}>): LiveAnnouncer', gave the following error.
Type '{ children: Element; }' has no properties in common with type 'IntrinsicAttributes & IntrinsicClassAttributes<LiveAnnouncer>'.
Overload 2 of 2, '(props: {}, context: any): LiveAnnouncer', gave the following error.
Type '{ children: Element; }' has no properties in common with type 'IntrinsicAttributes & IntrinsicClassAttributes<LiveAnnouncer>' @definitelytyped/expect
✖ 2 problems (2 errors, 0 warnings)
at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.4_typescript@5.4.0-dev.20240130/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.4_typescript@5.4.0-dev.20240130/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)
Package: react-instantsearch-native Error:
/home/vsts/work/1/DefinitelyTyped/types/react-instantsearch-native/react-instantsearch-native-tests.tsx
12:10 error TypeScript@local compile error:
Type '{ children: Element; }' has no properties in common with type 'IntrinsicAttributes & IntrinsicClassAttributes<Component<{}, any, any>>' @definitelytyped/expect
15:22 error TypeScript@local compile error:
Type '{ children: Element; }' has no properties in common with type 'IntrinsicAttributes & IntrinsicClassAttributes<Component<{}, any, any>>' @definitelytyped/expect
23:22 error TypeScript@local compile error:
Type '{ children: Element; }' has no properties in common with type 'IntrinsicAttributes & IntrinsicClassAttributes<Component<{}, any, any>>' @definitelytyped/expect
31:22 error TypeScript@local compile error:
Type '{ children: Element; }' has no properties in common with type 'IntrinsicAttributes & IntrinsicClassAttributes<Component<{}, any, any>>' @definitelytyped/expect
✖ 4 problems (4 errors, 0 warnings)
at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.4_typescript@5.4.0-dev.20240130/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.4_typescript@5.4.0-dev.20240130/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)
Package: reactable Error:
/home/vsts/work/1/DefinitelyTyped/types/reactable/reactable-tests.tsx
71:18 error TypeScript@local compile error:
Type '{ children: Element[]; }' has no properties in common with type 'IntrinsicAttributes & IntrinsicClassAttributes<Thead>' @definitelytyped/expect
75:18 error TypeScript@local compile error:
Type '{ children: Element; }' has no properties in common with type 'IntrinsicAttributes & IntrinsicClassAttributes<Tfoot>' @definitelytyped/expect
✖ 2 problems (2 errors, 0 warnings)
at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.4_typescript@5.4.0-dev.20240130/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.4_typescript@5.4.0-dev.20240130/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)
Package: relay-test-utils Error:
/home/vsts/work/1/DefinitelyTyped/types/relay-test-utils/test/classical.tsx
22:17 error TypeScript@local compile error:
Argument of type 'Container<Omit<unknown, "relay">>' is not assignable to parameter of type 'ComponentType<RelayProp | RelayPaginationProp | RelayRefetchProp | { componentRef?: ((ref: any) => void) | undefined; }>'.
Type 'ComponentClass<{ componentRef?: ((ref: any) => void) | undefined; }, any>' is not assignable to type 'ComponentType<RelayProp | RelayPaginationProp | RelayRefetchProp | { componentRef?: ((ref: any) => void) | undefined; }>'.
Type 'ComponentClass<{ componentRef?: ((ref: any) => void) | undefined; }, any>' is not assignable to type 'ComponentClass<RelayProp | RelayPaginationProp | RelayRefetchProp | { componentRef?: ((ref: any) => void) | undefined; }, any>'.
Types of property 'getDerivedStateFromProps' are incompatible.
Type 'GetDerivedStateFromProps<{ componentRef?: ((ref: any) => void) | undefined; }, any> | undefined' is not assignable to type 'GetDerivedStateFromProps<RelayProp | RelayPaginationProp | RelayRefetchProp | { componentRef?: ((ref: any) => void) | undefined; }, any> | undefined'.
Type 'GetDerivedStateFromProps<{ componentRef?: ((ref: any) => void) | undefined; }, any>' is not assignable to type 'GetDerivedStateFromProps<RelayProp | RelayPaginationProp | RelayRefetchProp | { componentRef?: ((ref: any) => void) | undefined; }, any>'.
Types of parameters 'nextProps' and 'nextProps' are incompatible.
Type 'Readonly<RelayProp | RelayPaginationProp | RelayRefetchProp | { componentRef?: ((ref: any) => void) | undefined; }>' is not assignable to type 'Readonly<{ componentRef?: ((ref: any) => void) | undefined; }>'.
Type 'Readonly<RelayProp>' has no properties in common with type 'Readonly<{ componentRef?: ((ref: any) => void) | undefined; }>' @definitelytyped/expect
✖ 1 problem (1 error, 0 warnings)
at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.4_typescript@5.4.0-dev.20240130/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.4_typescript@5.4.0-dev.20240130/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)
Package: react-native-modals Error:
/home/vsts/work/1/DefinitelyTyped/types/react-native-modals/react-native-modals-tests.tsx
117:14 error TypeScript@local compile error:
No overload matches this call.
Overload 1 of 2, '(props: {} | Readonly<{}>): ModalPortal', gave the following error.
Type '{ children: Element[]; }' has no properties in common with type 'IntrinsicAttributes & IntrinsicClassAttributes<ModalPortal>'.
Overload 2 of 2, '(props: {}, context: any): ModalPortal', gave the following error.
Type '{ children: Element[]; }' has no properties in common with type 'IntrinsicAttributes & IntrinsicClassAttributes<ModalPortal>' @definitelytyped/expect
✖ 1 problem (1 error, 0 warnings)
at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.4_typescript@5.4.0-dev.20240130/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.4_typescript@5.4.0-dev.20240130/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)
Package: solid__react Error:
/home/vsts/work/1/DefinitelyTyped/types/solid__react/solid__react-tests.tsx
32:14 error TypeScript@local compile error:
No overload matches this call.
Overload 1 of 2, '(props: {} | Readonly<{}>): LoggedIn', gave the following error.
Type '{ children: string; }' has no properties in common with type 'IntrinsicAttributes & IntrinsicClassAttributes<LoggedIn>'.
Overload 2 of 2, '(props: {}, context: any): LoggedIn', gave the following error.
Type '{ children: string; }' has no properties in common with type 'IntrinsicAttributes & IntrinsicClassAttributes<LoggedIn>' @definitelytyped/expect
33:14 error TypeScript@local compile error:
No overload matches this call.
Overload 1 of 2, '(props: {} | Readonly<{}>): LoggedOut', gave the following error.
Type '{ children: string; }' has no properties in common with type 'IntrinsicAttributes & IntrinsicClassAttributes<LoggedOut>'.
Overload 2 of 2, '(props: {}, context: any): LoggedOut', gave the following error.
Type '{ children: string; }' has no properties in common with type 'IntrinsicAttributes & IntrinsicClassAttributes<LoggedOut>' @definitelytyped/expect
✖ 2 problems (2 errors, 0 warnings)
at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.4_typescript@5.4.0-dev.20240130/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.4_typescript@5.4.0-dev.20240130/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)
Package: react-gateway Error:
/home/vsts/work/1/DefinitelyTyped/types/react-gateway/react-gateway-tests.tsx
25:14 error TypeScript@local compile error:
No overload matches this call.
Overload 1 of 2, '(props: {} | Readonly<{}>): GatewayProvider', gave the following error.
Type '{ children: Element[]; }' has no properties in common with type 'IntrinsicAttributes & IntrinsicClassAttributes<GatewayProvider>'.
Overload 2 of 2, '(props: {}, context: any): GatewayProvider', gave the following error.
Type '{ children: Element[]; }' has no properties in common with type 'IntrinsicAttributes & IntrinsicClassAttributes<GatewayProvider>' @definitelytyped/expect
✖ 1 problem (1 error, 0 warnings)
at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.4_typescript@5.4.0-dev.20240130/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.4_typescript@5.4.0-dev.20240130/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)
Package: react-helmet-with-visor Error:
/home/vsts/work/1/DefinitelyTyped/types/react-helmet-with-visor/react-helmet-with-visor-tests.tsx
10:14 error TypeScript@local compile error:
No overload matches this call.
Overload 1 of 2, '(props: {} | Readonly<{}>): HelmetsOpenedVisor', gave the following error.
Type '{ children: string; }' has no properties in common with type 'IntrinsicAttributes & IntrinsicClassAttributes<HelmetsOpenedVisor>'.
Overload 2 of 2, '(props: {}, context: any): HelmetsOpenedVisor', gave the following error.
Type '{ children: string; }' has no properties in common with type 'IntrinsicAttributes & IntrinsicClassAttributes<HelmetsOpenedVisor>' @definitelytyped/expect
131:6 error TypeScript@local compile error:
No overload matches this call.
Overload 1 of 2, '(props: {} | Readonly<{}>): HelmetsOpenedVisor', gave the following error.
Type '{ children: string; }' has no properties in common with type 'IntrinsicAttributes & IntrinsicClassAttributes<HelmetsOpenedVisor>'.
Overload 2 of 2, '(props: {}, context: any): HelmetsOpenedVisor', gave the following error.
Type '{ children: string; }' has no properties in common with type 'IntrinsicAttributes & IntrinsicClassAttributes<HelmetsOpenedVisor>' @definitelytyped/expect
✖ 2 problems (2 errors, 0 warnings)
at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.4_typescript@5.4.0-dev.20240130/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.4_typescript@5.4.0-dev.20240130/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)
Package: react-instantsearch-core Error:
/home/vsts/work/1/DefinitelyTyped/types/react-instantsearch-core/react-instantsearch-core-tests.tsx
113:6 error TypeScript@local compile error:
Type '{ children: Element; }' has no properties in common with type 'IntrinsicAttributes & IntrinsicClassAttributes<Component<{}, any, any>>' @definitelytyped/expect
✖ 1 problem (1 error, 0 warnings)
at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.4_typescript@5.4.0-dev.20240130/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.4_typescript@5.4.0-dev.20240130/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)
Package: dom-css Error:
/home/vsts/work/1/DefinitelyTyped/types/dom-css/dom-css-tests.ts
33:1 error TypeScript@local expected type to be:
{ left: string; marginTop: string; }
got:
{ [x: string]: string; } @definitelytyped/expect
✖ 1 problem (1 error, 0 warnings)
at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.4_typescript@5.4.0-dev.20240130/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.4_typescript@5.4.0-dev.20240130/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)
Package: react-instantsearch Error:
/home/vsts/work/1/DefinitelyTyped/types/react-instantsearch/react-instantsearch-tests.tsx
275:14 error TypeScript@local compile error:
Type '{ children: Element; }' has no properties in common with type 'IntrinsicAttributes & IntrinsicClassAttributes<Component<{}, any, any>>' @definitelytyped/expect
278:26 error TypeScript@local compile error:
Type '{ children: Element; }' has no properties in common with type 'IntrinsicAttributes & IntrinsicClassAttributes<Component<{}, any, any>>' @definitelytyped/expect
286:26 error TypeScript@local compile error:
Type '{ children: Element; }' has no properties in common with type 'IntrinsicAttributes & IntrinsicClassAttributes<Component<{}, any, any>>' @definitelytyped/expect
294:26 error TypeScript@local compile error:
Type '{ children: Element; }' has no properties in common with type 'IntrinsicAttributes & IntrinsicClassAttributes<Component<{}, any, any>>' @definitelytyped/expect
✖ 4 problems (4 errors, 0 warnings)
at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.4_typescript@5.4.0-dev.20240130/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.4_typescript@5.4.0-dev.20240130/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)
Package: react-switch-case Error:
/home/vsts/work/1/DefinitelyTyped/types/react-switch-case/react-switch-case-tests.tsx
16:18 error TypeScript@local compile error:
No overload matches this call.
Overload 1 of 2, '(props: {} | Readonly<{}>): Default', gave the following error.
Type '{ children: Element; }' has no properties in common with type 'IntrinsicAttributes & IntrinsicClassAttributes<Default>'.
Overload 2 of 2, '(props: {}, context: any): Default', gave the following error.
Type '{ children: Element; }' has no properties in common with type 'IntrinsicAttributes & IntrinsicClassAttributes<Default>' @definitelytyped/expect
✖ 1 problem (1 error, 0 warnings)
at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.4_typescript@5.4.0-dev.20240130/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.4_typescript@5.4.0-dev.20240130/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)
Package: jest Error:
/home/vsts/work/1/DefinitelyTyped/types/jest/jest-tests.ts
769:1 error TypeScript@local expected type to be:
MockedObjectDeep<{}>
got:
{} @definitelytyped/expect
771:1 error TypeScript@local expected type to be:
MockedObjectDeep<{}>
got:
{} @definitelytyped/expect
773:1 error TypeScript@local expected type to be:
MockedObject<{}>
got:
{} @definitelytyped/expect
✖ 3 problems (3 errors, 0 warnings)
at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.4_typescript@5.4.0-dev.20240130/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.4_typescript@5.4.0-dev.20240130/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Gabriela Araujo Britto (@gabritto) Here are the results of running the top-repos suite comparing main and refs/pull/56974/merge: Something interesting changed - please have a look. Detailsapollographql/apollo-client1 of 12 projects failed to build with the old tsc and were ignored src/tsconfig.json
AykutSarac/jsoncrack.comtsconfig.json
date-fns/date-fns2 of 4 projects failed to build with the old tsc and were ignored tsconfig.json
nextauthjs/next-auth15 of 38 projects failed to build with the old tsc and were ignored packages/adapter-drizzle/tsconfig.json
recharts/recharts1 of 3 projects failed to build with the old tsc and were ignored demo/tsconfig.json
tsconfig.json
slidevjs/slidevpackages/slidev/tsconfig.json
tsconfig.json
TanStack/query52 of 60 projects failed to build with the old tsc and were ignored tsconfig.json
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Seems like there are many breaks on the top repos test :/ |
Sorry, something went wrong.
Gabriela Araujo Britto (gabritto)
requested changes
Apr 30, 2024
Gabriela Araujo Britto (gabritto)
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
With 6.0 out as the final release vehicle for this codebase, we're closing all PRs that don't fit the merge criteria for post-6.0 patches. If you think this was a mistake and this PR fits the post-6.0 patch criteria, please post to the 6.0 iteration issue with details (specifically, which PR and which patch criteria it satisfies). Next steps for PRs:
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #56691
This makes non-generic mapped types with never constraints behave like {} (since it displays as {}). "If it looks like a duck, swims like a duck, and quacks like a duck, then it probably is a duck."