FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(58955): @import JSDoc tag doesn't seem to account for resolution-mode import attribute in TS v5.5.2 by a-tarasyuk · Pull Request #58966 · microsoft/TypeScript · GitHub

/ TypeScript Public

fix(58955): @import JSDoc tag doesn't seem to account for resolution-mode import attribute in TS v5.5.2 - #58966

Merged
Jake Bailey (jakebailey) merged 2 commits into
microsoft:mainfrom
a-tarasyuk:fix/58955
Jun 24, 2024
ConversationCommits (2)ChecksFiles changed
Merged

fix(58955): @import JSDoc tag doesn't seem to account for resolution-mode import attribute in TS v5.5.2#58966
Jake Bailey (jakebailey) merged 2 commits into
microsoft:mainfrom
a-tarasyuk:fix/58955

Conversation

Oleksandr Tarasiuk (a-tarasyuk) commented Jun 21, 2024

Copy link
Copy Markdown
Contributor

Fixes #58955

TypeScript Bot (typescript-bot) added the For Milestone Bug PRs that fix a bug with a specific milestone label Jun 21, 2024
Jake Bailey (jakebailey) approved these changes Jun 24, 2024
View reviewed changes

Jake Bailey (jakebailey) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This seems correct to me. Probably worth the 5.5 backport.

Andrew Branch (andrewbranch) approved these changes Jun 24, 2024
View reviewed changes

Andrew Branch (andrewbranch) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks Oleksandr Tarasiuk (@a-tarasyuk)!

Andrew Branch (andrewbranch) commented Jun 24, 2024

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) cherry-pick to release-5.5

TypeScript Bot (typescript-bot) commented Jun 24, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
cherry-pick to release-5.5 ✅ Started ❌ Results

TypeScript Bot (typescript-bot) commented Jun 24, 2024

Copy link
Copy Markdown
Contributor

Hey, Andrew Branch (@andrewbranch)! I was unable to cherry-pick this PR.

Check the logs at: https://github.com/microsoft/TypeScript/actions/runs/9650506935

Jake Bailey (jakebailey) commented Jun 24, 2024

Copy link
Copy Markdown
Member

I expect cherry-picking to fail just because these lines are ones that changed in the 5.5 bump for type predicate inference...

Oleksandr Tarasiuk (a-tarasyuk) commented Jun 24, 2024

Copy link
Copy Markdown
Contributor Author

Jake Bailey (@jakebailey) should I make a new PR to the release branch?

Jake Bailey (jakebailey) commented Jun 24, 2024

Copy link
Copy Markdown
Member

No worries, I'll do it.

Jake Bailey (jakebailey) merged commit c219989 into microsoft:main Jun 24, 2024
Jake Bailey (jakebailey) pushed a commit to jakebailey/TypeScript that referenced this pull request Jun 24, 2024
fix(58955): @import JSDoc tag doesn't seem to account for resolution-…
6738ddd 
…mode import attribute in TS v5.5.2 (microsoft#58966)
Daniel Rosenwasser (DanielRosenwasser) pushed a commit that referenced this pull request Jun 26, 2024
Cherry-pick #58966 to release-5.5 (#59002)
738bd60 
Co-authored-by: Oleksandr T <oleksandr.tarasiuk@outlook.com>
Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Andrew Branch (andrewbranch) andrewbranch approved these changes
Jake Bailey (jakebailey) jakebailey approved these changes

Assignees

Andrew Branch (andrewbranch)

Labels

For Milestone Bug PRs that fix a bug with a specific milestone

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

@import JSDoc tag doesn't seem to account for resolution-mode import attribute in TS v5.5.2

5 participants

Back | FazBrowse Home | New Git URL