FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix inconsistent generic indexed access by ahejlsberg · Pull Request #59415 · microsoft/TypeScript · GitHub

/ TypeScript Public

Fix inconsistent generic indexed access - #59415

Closed
Anders Hejlsberg (ahejlsberg) wants to merge 3 commits into
mainfrom
fixInconsistentGenericIndexedAccess
ConversationCommits (3)ChecksFiles changed
Closed

Fix inconsistent generic indexed access#59415
Anders Hejlsberg (ahejlsberg) wants to merge 3 commits into
mainfrom
fixInconsistentGenericIndexedAccess

Conversation

Anders Hejlsberg (ahejlsberg) commented Jul 24, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes the issue reported here. Rationale for fix in comment here.

TypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jul 24, 2024

Anders Hejlsberg (ahejlsberg) commented Jul 24, 2024

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) test it

TypeScript Bot (typescript-bot) commented Jul 24, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top400 ✅ Started ✅ Results
user test this ✅ Started ✅ Results
run dt ✅ Started ✅ Results
perf test this faster ✅ Started 👀 Results

TypeScript Bot (typescript-bot) commented Jul 24, 2024

Copy link
Copy Markdown
Contributor

Hey Anders Hejlsberg (@ahejlsberg), the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

TypeScript Bot (typescript-bot) commented Jul 24, 2024

Copy link
Copy Markdown
Contributor

Anders Hejlsberg (@ahejlsberg) Here are the results of running the user tests with tsc comparing main and refs/pull/59415/merge:

Everything looks good!

TypeScript Bot (typescript-bot) commented Jul 24, 2024

Copy link
Copy Markdown
Contributor

Anders Hejlsberg (@ahejlsberg)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - node (v18.15.0, x64)
Errors 30 30 ~ ~ ~ p=1.000 n=6
Symbols 62,153 62,153 ~ ~ ~ p=1.000 n=6
Types 50,242 50,242 ~ ~ ~ p=1.000 n=6
Memory used 193,432k (± 0.94%) 193,444k (± 0.97%) ~ 192,202k 195,880k p=1.000 n=6
Parse Time 1.95s (± 0.53%) 1.95s (± 0.32%) ~ 1.94s 1.96s p=0.443 n=6
Bind Time 1.05s (± 1.27%) 1.06s (± 1.14%) ~ 1.05s 1.08s p=0.101 n=6
Check Time 13.97s (± 0.47%) 14.03s (± 0.60%) ~ 13.93s 14.18s p=0.261 n=6
Emit Time 4.05s (± 0.58%) 4.02s (± 0.67%) ~ 3.99s 4.06s p=0.106 n=6
Total Time 21.02s (± 0.25%) 21.06s (± 0.42%) ~ 20.95s 21.20s p=0.520 n=6
angular-1 - node (v18.15.0, x64)
Errors 7 7 ~ ~ ~ p=1.000 n=6
Symbols 945,532 945,532 ~ ~ ~ p=1.000 n=6
Types 409,507 409,507 ~ ~ ~ p=1.000 n=6
Memory used 1,221,095k (± 0.00%) 1,221,117k (± 0.01%) ~ 1,221,022k 1,221,197k p=0.378 n=6
Parse Time 7.87s (± 0.65%) 7.89s (± 0.65%) ~ 7.82s 7.96s p=0.629 n=6
Bind Time 2.19s (± 0.38%) 2.21s (± 1.27%) ~ 2.19s 2.27s p=0.065 n=6
Check Time 36.31s (± 0.45%) 36.27s (± 0.34%) ~ 36.14s 36.42s p=0.575 n=6
Emit Time 17.79s (± 0.93%) 17.73s (± 0.48%) ~ 17.64s 17.87s p=0.873 n=6
Total Time 64.16s (± 0.34%) 64.11s (± 0.20%) ~ 63.94s 64.30s p=1.000 n=6
mui-docs - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 2,324,872 2,324,872 ~ ~ ~ p=1.000 n=6
Types 949,556 949,556 ~ ~ ~ p=1.000 n=6
Memory used 2,222,598k (± 0.00%) 2,222,617k (± 0.00%) ~ 2,222,523k 2,222,711k p=0.689 n=6
Parse Time 6.63s (± 0.49%) 6.65s (± 0.41%) ~ 6.61s 6.69s p=0.334 n=6
Bind Time 2.33s (± 0.45%) 2.32s (± 0.59%) ~ 2.30s 2.34s p=1.000 n=6
Check Time 73.04s (± 0.34%) 73.18s (± 0.35%) ~ 72.87s 73.44s p=0.471 n=6
Emit Time 0.14s (± 3.77%) 0.14s (± 2.95%) ~ 0.13s 0.14s p=0.595 n=6
Total Time 82.13s (± 0.30%) 82.29s (± 0.30%) ~ 81.98s 82.54s p=0.298 n=6
self-build-src - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,230,120 1,230,118 -2 (- 0.00%) ~ ~ p=0.001 n=6
Types 265,641 265,639 -2 (- 0.00%) ~ ~ p=0.001 n=6
Memory used 2,347,392k (± 0.02%) 2,347,464k (± 0.02%) ~ 2,347,024k 2,347,871k p=0.873 n=6
Parse Time 4.99s (± 0.74%) 5.00s (± 1.13%) ~ 4.94s 5.08s p=0.810 n=6
Bind Time 1.90s (± 0.43%) 1.90s (± 0.27%) ~ 1.89s 1.90s p=0.929 n=6
Check Time 34.68s (± 0.44%) 34.72s (± 0.25%) ~ 34.63s 34.88s p=0.423 n=6
Emit Time 3.28s (± 0.71%) 3.29s (± 0.80%) ~ 3.26s 3.33s p=0.470 n=6
Total Time 44.86s (± 0.37%) 44.93s (± 0.15%) ~ 44.88s 45.06s p=0.575 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,230,120 1,230,118 -2 (- 0.00%) ~ ~ p=0.001 n=6
Types 265,641 265,639 -2 (- 0.00%) ~ ~ p=0.001 n=6
Memory used 2,421,655k (± 0.03%) 2,421,770k (± 0.04%) ~ 2,421,147k 2,423,557k p=0.575 n=6
Parse Time 6.25s (± 0.97%) 6.28s (± 0.45%) ~ 6.24s 6.31s p=0.378 n=6
Bind Time 2.06s (± 1.00%) 2.05s (± 0.84%) ~ 2.02s 2.07s p=0.294 n=6
Check Time 41.39s (± 0.39%) 41.45s (± 0.35%) ~ 41.31s 41.68s p=0.810 n=6
Emit Time 4.07s (± 3.33%) 4.05s (± 1.45%) ~ 3.97s 4.12s p=1.000 n=6
Total Time 53.78s (± 0.36%) 53.83s (± 0.37%) ~ 53.60s 54.14s p=0.873 n=6
self-compiler - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 258,471 258,469 -2 (- 0.00%) ~ ~ p=0.001 n=6
Types 105,534 105,532 -2 (- 0.00%) ~ ~ p=0.001 n=6
Memory used 429,148k (± 0.04%) 429,030k (± 0.01%) ~ 428,997k 429,068k p=0.092 n=6
Parse Time 3.34s (± 1.23%) 3.36s (± 0.52%) ~ 3.33s 3.37s p=0.361 n=6
Bind Time 1.32s (± 1.70%) 1.33s (± 0.78%) ~ 1.32s 1.35s p=0.558 n=6
Check Time 18.05s (± 0.46%) 18.02s (± 0.41%) ~ 17.93s 18.11s p=0.521 n=6
Emit Time 1.64s (± 2.13%) 1.64s (± 1.63%) ~ 1.61s 1.67s p=0.871 n=6
Total Time 24.36s (± 0.56%) 24.34s (± 0.40%) ~ 24.23s 24.46s p=1.000 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors 35 35 ~ ~ ~ p=1.000 n=6
Symbols 224,931 224,931 ~ ~ ~ p=1.000 n=6
Types 94,146 94,146 ~ ~ ~ p=1.000 n=6
Memory used 370,025k (± 0.03%) 370,033k (± 0.03%) ~ 369,852k 370,115k p=1.000 n=6
Parse Time 2.75s (± 1.05%) 2.77s (± 0.67%) ~ 2.73s 2.78s p=0.288 n=6
Bind Time 1.58s (± 0.87%) 1.59s (± 1.05%) ~ 1.57s 1.61s p=0.303 n=6
Check Time 15.64s (± 0.13%) 15.65s (± 0.56%) ~ 15.53s 15.79s p=1.000 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 19.97s (± 0.23%) 20.01s (± 0.46%) ~ 19.87s 20.14s p=0.336 n=6
vscode - node (v18.15.0, x64)
Errors 11 11 ~ ~ ~ p=1.000 n=6
Symbols 2,985,953 2,985,953 ~ ~ ~ p=1.000 n=6
Types 1,027,137 1,027,137 ~ ~ ~ p=1.000 n=6
Memory used 3,109,965k (± 0.00%) 3,109,957k (± 0.00%) ~ 3,109,892k 3,110,051k p=0.810 n=6
Parse Time 13.81s (± 0.33%) 13.81s (± 0.19%) ~ 13.78s 13.85s p=0.628 n=6
Bind Time 4.29s (± 2.13%) 4.25s (± 0.38%) ~ 4.24s 4.28s p=0.186 n=6
Check Time 78.82s (± 0.14%) 78.80s (± 0.34%) ~ 78.41s 79.09s p=0.936 n=6
Emit Time 20.39s (± 0.52%) 20.44s (± 0.61%) ~ 20.28s 20.61s p=0.469 n=6
Total Time 117.31s (± 0.16%) 117.30s (± 0.14%) ~ 117.10s 117.47s p=0.936 n=6
webpack - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 267,560 267,560 ~ ~ ~ p=1.000 n=6
Types 109,076 109,076 ~ ~ ~ p=1.000 n=6
Memory used 412,503k (± 0.01%) 412,422k (± 0.01%) -81k (- 0.02%) 412,373k 412,481k p=0.020 n=6
Parse Time 4.76s (± 0.68%) 4.75s (± 0.67%) ~ 4.70s 4.80s p=0.570 n=6
Bind Time 2.13s (± 0.65%) 2.11s (± 0.52%) ~ 2.10s 2.13s p=0.066 n=6
Check Time 20.82s (± 0.34%) 20.79s (± 0.31%) ~ 20.71s 20.90s p=0.471 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 27.71s (± 0.24%) 27.65s (± 0.28%) ~ 27.57s 27.78s p=0.196 n=6
xstate-main - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 511,803 511,803 ~ ~ ~ p=1.000 n=6
Types 162,088 162,088 ~ ~ ~ p=1.000 n=6
Memory used 449,248k (± 0.06%) 449,327k (± 0.03%) ~ 449,129k 449,450k p=0.689 n=6
Parse Time 2.61s (± 0.31%) 2.63s (± 0.57%) ~ 2.61s 2.65s p=0.116 n=6
Bind Time 0.97s (± 0.53%) 0.97s (± 1.51%) ~ 0.96s 1.00s p=0.784 n=6
Check Time 14.60s (± 0.37%) 14.57s (± 0.31%) ~ 14.51s 14.63s p=0.520 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 18.18s (± 0.28%) 18.17s (± 0.28%) ~ 18.09s 18.22s p=0.873 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

TypeScript Bot (typescript-bot) commented Jul 25, 2024

Copy link
Copy Markdown
Contributor

Anders Hejlsberg (@ahejlsberg) Here are the results of running the top 400 repos with tsc comparing main and refs/pull/59415/merge:

Everything looks good!

Anders Hejlsberg (ahejlsberg) mentioned this pull request Jul 26, 2024
Closed

TypeScript Bot (typescript-bot) commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

With 6.0 out as the final release vehicle for this codebase, we're closing all PRs that don't fit the merge criteria for post-6.0 patches. If you think this was a mistake and this PR fits the post-6.0 patch criteria, please post to the 6.0 iteration issue with details (specifically, which PR and which patch criteria it satisfies).

Next steps for PRs:

  • For crash bugfixes or language service improvements, PRs are currently accepted at the typescript-go repo
  • Changes to type system behavior should wait until after 7.0, at which point mainline TypeScript development will resume in this repository with the Go codebase
  • Library file updates (lib.d.ts etc) continue to live in this repo or the DOM Generator repo as appropriate

github-project-automation Bot moved this from Not started to Done in PR Backlog Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Daniel Rosenwasser (DanielRosenwasser) Awaiting requested review from DanielRosenwasser

Assignees

Anders Hejlsberg (ahejlsberg)

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

PR Backlog
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL