Ban non-ambient namespaces written with module keyword - #61450
Closed
Ryan Cavanaugh (RyanCavanaugh) wants to merge 4 commits into
Closed
Ban non-ambient namespaces written with module keyword#61450Ryan Cavanaugh (RyanCavanaugh) wants to merge 4 commits into
Ryan Cavanaugh (RyanCavanaugh) wants to merge 4 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
TypeScript Bot (@typescript-bot) test top800 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Starting jobs; this comment will be updated as builds start and complete.
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Ryan Cavanaugh (@RyanCavanaugh) Here are the results of running the top 800 repos with tsc comparing main and refs/pull/61450/merge: Something interesting changed - please have a look. DetailsTypeStrong/typedoc1 of 4 projects failed to build with the old tsc and were ignored src/test/converter/tsconfig.json
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
TypeScript Bot (@typescript-bot) test top800 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Starting jobs; this comment will be updated as builds start and complete.
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Hey Ryan Cavanaugh (@RyanCavanaugh), the results of running the DT tests are ready. Everything looks the same! |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Ryan Cavanaugh (@RyanCavanaugh) Here are the results of running the top 800 repos with tsc comparing main and refs/pull/61450/merge: Something interesting changed - please have a look. Detailsblitz-js/blitz25 of 27 projects failed to build with the old tsc and were ignored packages/generator/tsconfig.json
TypeStrong/typedoc1 of 4 projects failed to build with the old tsc and were ignored src/test/converter/tsconfig.json
visgl/react-map-gl11 of 40 projects failed to build with the old tsc and were ignored modules/main/tsconfig.json
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
gl-matrix builds index.d.ts from JS source (with --module amd --outFile!), but then patches out declare module "sub" { with declare module sub { with a custom build script |
Sorry, something went wrong.
Rob Palmer (robpalme)
added a commit
to robpalme/gl-matrix
that referenced
this pull request
Jul 12, 2025
Previously some namespace types were generated using the legacy `module` keyword from ten years ago. Now we emit the modern TS `namespace` keyword that has been the preferred keyword since TypeScript 1.5 in 2015. Please review the resulting diff for the generated `dist/index.d.ts` file: https://gist.github.com/robpalme/a320dc3f0cb50bcd14962bca46827dae/revisions Note that the outer _Ambient Module Declaration_ intentionally remains untouched because it is not a namespace. These are differentiated by using a quoted string rather than a bare identifier `module "quoted" {` vs `module bare {}` --- Background: This usage of the legacy keyword was found by [a TypeScript real-world test suite](microsoft/TypeScript#61450 (comment)) that checks the compatibility of proposed changes. Using the `module` keyword for namespaces is [proposed for deprecation in TypeScript 6.0](microsoft/TypeScript#54500 (comment)) so it's worth getting ahead of this.
Brandon Jones (toji)
pushed a commit
to toji/gl-matrix
that referenced
this pull request
Jul 14, 2025
Previously some namespace types were generated using the legacy `module` keyword from ten years ago. Now we emit the modern TS `namespace` keyword that has been the preferred keyword since TypeScript 1.5 in 2015. Please review the resulting diff for the generated `dist/index.d.ts` file: https://gist.github.com/robpalme/a320dc3f0cb50bcd14962bca46827dae/revisions Note that the outer _Ambient Module Declaration_ intentionally remains untouched because it is not a namespace. These are differentiated by using a quoted string rather than a bare identifier `module "quoted" {` vs `module bare {}` --- Background: This usage of the legacy keyword was found by [a TypeScript real-world test suite](microsoft/TypeScript#61450 (comment)) that checks the compatibility of proposed changes. Using the `module` keyword for namespaces is [proposed for deprecation in TypeScript 6.0](microsoft/TypeScript#54500 (comment)) so it's worth getting ahead of this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft PR to assess the prevalence of these in the wild (error message is reusing the ESO one).