Repository navigation
Fix crash on malformed object destructuring assignment in decorated class - #64472
Mateusz Burzyński (Andarist) wants to merge 2 commits into
Conversation
Sorry, something went wrong.
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Sorry, something went wrong.
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The crash should be fixed without removing an existing debug assertion and masking the visitor-contract violation.
Review effort: Balanced
Findings: 1
Adds regression coverage for malformed object destructuring inside a decorated class.
Changes:
- Adds a malformed destructuring compiler test.
- Adds diagnostic, emit, symbol, and type baselines.
- Removes an assertion from the ES decorator transformer.
| File | Description |
|---|---|
| tsc/internal/transformers/estransforms/esdecorator.go | Avoids the reported crash by removing an assertion. |
| tsc/testdata/tests/cases/compiler/malformedObjectDestructuringAssignmentESDecorators.ts | Adds the regression case. |
| tsc/testdata/baselines/reference/compiler/malformedObjectDestructuringAssignmentESDecorators.errors.txt | Records expected diagnostics. |
| tsc/testdata/baselines/reference/compiler/malformedObjectDestructuringAssignmentESDecorators.js | Records expected emit. |
| tsc/testdata/baselines/reference/compiler/malformedObjectDestructuringAssignmentESDecorators.symbols | Records expected symbols. |
| tsc/testdata/baselines/reference/compiler/malformedObjectDestructuringAssignmentESDecorators.types | Records expected types. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
| @@ -2261,7 +2261,6 @@ func (tx *esDecoratorTransformer) visitAssignmentRestProperty(node *ast.Node) *a | |||
| } | |||
|
|
|||
| func (tx *esDecoratorTransformer) visitObjectAssignmentElement(node *ast.Node) *ast.Node { | |||
There was a problem hiding this comment.
Yes, removing an assert without an explanation is dubious.
Sorry, something went wrong.
fixes a crash reported here: #64458 (comment)
This PR is similar to #63972 and #63973