Repository navigation
Release unused LSP configured projects during idle cleanup - #64603
Open
Ryan Cavanaugh (RyanCavanaugh) wants to merge 3 commits into
Open
Ryan Cavanaugh (RyanCavanaugh) wants to merge 3 commits into
Ryan Cavanaugh (RyanCavanaugh) wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Fixes microsoft#64463 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f12493fa-9c70-40a4-a2de-c498d69f0aa4
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
Review effort: Lite
Findings: 1 · 2
retain is created as the zero value and passed to cleanupConfiguredProjects. If… · New
Cleanup runs before DidRequestFile processes change.Documents. If an idle-clean snapshot update… · New
Implements idle cleanup behavior that unloads unused LSP configured projects (and associated disk cache/config registry entries) while keeping actively used and referenced projects retained.
Changes:
- Invoke configured-project cleanup during idle disk cache cleanup snapshot updates.
- Add snapshot tests covering: releasing unused projects, retaining API-opened projects/files, and retaining referenced projects.
- Update comments to reflect idle cleanup now includes unloading projects.
| File | Description |
|---|---|
| tsc/internal/project/snapshot.go | Triggers configured-project cleanup during idle cleanup snapshot cloning. |
| tsc/internal/project/snapshot_test.go | Adds coverage for idle cleanup project release/retention scenarios. |
| tsc/internal/project/session.go | Updates idle cleanup timer comment to include unloading unused projects. |
| tsc/internal/project/projectcollectionbuilder.go | Updates cleanupConfiguredProjects doc comment to mention idle cleanup. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
Comment thread
tsc/internal/project/snapshot.go
Outdated
Comment thread
tsc/internal/project/snapshot.go
Comment thread
tsc/internal/project/snapshot_test.go
Resolve conflicts and adapt the idle cleanup regression tests to main's file-cache and API changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f12493fa-9c70-40a4-a2de-c498d69f0aa4
Copilot started reviewing on behalf of
Ryan Cavanaugh (RyanCavanaugh)
October 2, 2026 18:52
View session
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
Review effort: Lite
Findings: 5
Sorry, something went wrong.
Comment thread
tsc/internal/project/snapshot.go
Comment thread
tsc/internal/project/snapshot_test.go
Outdated
Comment thread
tsc/internal/project/snapshot_test.go
Outdated
Comment thread
tsc/internal/project/snapshot_test.go
Comment thread
tsc/internal/project/snapshot_test.go
Copilot started reviewing on behalf of
Ryan Cavanaugh (RyanCavanaugh)
October 2, 2026 20:51
View session
Adapt to upstream path types, clarify the idle cleanup reason, and add explicit project retention assertions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f12493fa-9c70-40a4-a2de-c498d69f0aa4
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64463
Author: Copilot / Sol 6.1