Repository navigation
Restore dependency-depth build scheduling - #64615
Open
Jake Bailey (jakebailey) wants to merge 2 commits into
Open
Jake Bailey (jakebailey) wants to merge 2 commits into
Jake Bailey (jakebailey) wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Parallel builders were consuming reporting order, which can leave a worker waiting on a dependency while independent projects stay queued. Project-scoped builds must retain their selected project set, and reporting must remain stable regardless of worker scheduling.
The scheduling regression needs coverage of full, selected-project, and references-only builds with two workers. The larger execution-mode matrix repeats unrelated behavior and obscures that purpose.
Jake Bailey (jakebailey)
requested review from
Isabel Duan (iisaduan)
and
a balanced review from Copilot
October 3, 2026 03:28
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused fix preserves dependency and reporting behavior, with regression coverage for all three build scopes and no identified blockers.
Review effort: Balanced
Findings: None
Restores dependency-depth scheduling after the Build Orchestrator API regression, reducing builder idle time while preserving reporting order.
Changes:
- Schedules full and selected builds by dependency depth.
- Adds regression coverage for full builds, selected projects, and references-only builds.
| File | Description |
|---|---|
| tsc/internal/execute/build/orchestrator.go | Applies dependency-depth scheduling to the selected build tasks. |
| tsc/internal/execute/build/graph_test.go | Verifies concurrent scheduling, reporting order, and selected outputs. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
At least 1 approving review is required to merge this pull request.
Assignees
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#64158 regressed #64220