Repository navigation
Handle JSDocParameterTag in ast.GetTypeAnnotationNode - #64617
Merged
Jake Bailey (jakebailey) merged 1 commit intoOct 6, 2026
Merged
Jake Bailey (jakebailey) merged 1 commit into
Jake Bailey (jakebailey) merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new AST utility behavior lacks a focused regression test.
Review effort: Balanced
Findings: 1
Extends AST type annotation lookup to handle JSDoc parameter tags consistently.
Changes:
- Adds KindJSDocParameterTag to GetTypeAnnotationNode.
| File | Description |
|---|---|
| tsc/internal/ast/utilities.go | Supports retrieving JSDoc parameter type expressions. |
Sorry, something went wrong.
Comment thread
tsc/internal/ast/utilities.go
| KindAsExpression, KindSatisfiesExpression, KindTypeAliasDeclaration, KindJSTypeAliasDeclaration, | ||
| KindNamedTupleMember, KindOptionalType, KindRestType, KindTemplateLiteralTypeSpan, KindJSDocTypeExpression, | ||
| KindJSDocPropertyTag, KindJSDocNullableType, KindJSDocNonNullableType, KindJSDocOptionalType: | ||
| KindJSDocParameterTag, KindJSDocPropertyTag, KindJSDocNullableType, KindJSDocNonNullableType, KindJSDocOptionalType: |
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Sorry, something went wrong.
Jake Bailey (jakebailey)
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just randomly noticed that GetTypeAnnotationNode calls Node.Type(), which handles both JSDoc parameter and property tags:
TypeScript/tsc/internal/ast/ast.go
Lines 669 to 670 in f9f8d01
but its own switch only includes property tags. So, for consistency, this function must have the parameter tag case missed in microsoft/typescript-go#900. No user-facing change, since the only caller doesn't pass JSDoc tags
TypeScript/tsc/internal/ls/completions.go
Lines 1120 to 1127 in f9f8d01