Repository navigation
Fix crash in decorator metadata emit for decorated object literal members - #64633
Conversation
Sorry, something went wrong.
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Sorry, something went wrong.
| tx.currentLexicalScope = node | ||
| } | ||
|
|
||
| func (tx *MetadataTransformer) visitObjectLiteralExpression(node *ast.Node) *ast.Node { |
There was a problem hiding this comment.
- test code is intentionally invalid but parsing-wise permitted, it only has grammar errors
- the transforms/emitting is traditionally OK with such inputs, doing its best to emit "something"
The fix here matches Strada conceptually. Strada passed down parent (also in the case of object literal expressions). This patch just reuses the neighboring pattern (the same thing as in visitClassExpression) for doing the equivalent here in Corsa
Sorry, something went wrong.
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new compiler test is missing required reference baselines.
Review effort: Balanced
Findings: 1
Fixes a decorator metadata emit crash involving decorated object literal members.
Changes:
- Tracks object literals as metadata-transform parents.
- Adds a compiler regression test.
| File | Description |
|---|---|
| metadata.go | Prevents object members from being treated as class elements. |
| decoratorMetadataObjectLiteralMethodNoCrash.ts | Covers top-level and class-nested object literals. |
Sorry, something went wrong.
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused parent-tracking fix addresses the reported nil dereference and includes comprehensive regression baselines.
Review effort: Balanced
Findings: None
Sorry, something went wrong.
fixes crash reported here #64613 (comment)