Repository navigation
[api] Report project reference diagnostics on programs without a config file - #64637
Merged
Andrew Branch (andrewbranch) merged 1 commit intoOct 6, 2026
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copilot started reviewing on behalf of
Christopher Plieger (cplieger)
October 5, 2026 10:29
View session
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused fix correctly uses the existing compiler-diagnostic fallback and includes regression coverage.
Review effort: Balanced
Findings: None
Prevents API crashes when synthetic programs without config files report project-reference diagnostics.
Changes:
- Adds a nil guard before accessing ConfigFile.
- Adds regression coverage for TS6306 reporting.
| File | Description |
|---|---|
| tsc/internal/tsoptions/tsconfigparsing.go | Falls back when reference syntax is unavailable. |
| tsc/internal/api/session_createprogram_test.go | Verifies non-composite reference diagnostics. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
Andrew Branch (andrewbranch)
approved these changes
Oct 6, 2026
Andrew Branch (andrewbranch)
enabled auto-merge
October 6, 2026 22:36
Christopher Plieger (cplieger)
deleted the
fix-api-nil-configfile-project-reference
branch
October 6, 2026 23:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64629
A program created through createPrograms has no configuration file, so its ParsedCommandLine.ConfigFile is nil. Any project reference diagnostic on such a program crashes the API server with a nil pointer dereference in CreateDiagnosticAtReferenceSyntax.
Impact: a tool that builds its own program for a repository that references a non-composite project kills the whole API server process, losing every open snapshot, and the tool sees only an EOF. That is an ordinary monorepo setup, where tsc -p reports TS6306 and keeps going, so an analyzer on the API stops on that repository instead of analyzing it.
CreateDiagnosticAtReferenceSyntax now returns nil when ConfigFile is nil, and its caller in verifyProjectReferences already falls back to a compiler diagnostic in that case.
TestCreateProgramReportsNonCompositeProjectReference creates such a program with a reference to a non-composite project and expects TS6306 as its only program diagnostic, and it panics without the fix.
I met this while building deadset-ts, the TypeScript analyzer of deadset, on the TypeScript 7 API. That work hit a small set of related defects, which is why a few reports come from me.
An AI coding agent wrote this patch. I have read, built and tested it and will handle the review.