check if import collides with exported local name - #7583
Merged
Vladimir Matveev (vladima) merged 1 commit intoMar 18, 2016
Merged
check if import collides with exported local name#7583Vladimir Matveev (vladima) merged 1 commit into
Vladimir Matveev (vladima) merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
src/compiler/checker.ts
| // and symbol.flags will contains combined representation for all merged declaration. | ||
| // Based on symbol.flags we can compute a set of excluded meanings (meaning that resolved alias should not have, | ||
| // otherwise it will conflict with some local declaration). Note that in addition to normal flags we include matching SymbolFlags.Export* | ||
| // in order to prevent collisions with declarations that were exported from the current module (they still contribute to local names). |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This means that previously we would correctly catch unexported functions, right? Like:
import {f} from "f1"
function f() { }
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
yes and we still do this
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
👍 |
Sorry, something went wrong.
1 similar comment
Copy link
Copy Markdown
Contributor
|
👍 |
Sorry, something went wrong.
Vladimir Matveev (vladima)
added a commit
that referenced
this pull request
Mar 18, 2016
check if import collides with exported local name
Vladimir Matveev (vladima)
added a commit
that referenced
this pull request
Mar 19, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #7195