Lanugage Service support for union types - #861
Merged
Mohamed Hegazy (mhegazy) merged 12 commits intoOct 11, 2014
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Conflicts: src/compiler/checker.ts src/services/services.ts
Copy link
Copy Markdown
Member
|
Probably could use some fourslash tests for generic type inference and type guards |
Sorry, something went wrong.
…ies of the union type but are properties on of one of its constituant types
Copy link
Copy Markdown
Member
|
👍 |
Sorry, something went wrong.
Comment thread
src/services/services.ts
Outdated
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
handle
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
done
Sorry, something went wrong.
Conflicts: src/compiler/checker.ts
Mohamed Hegazy (mhegazy)
added a commit
that referenced
this pull request
Oct 11, 2014
Lanugage Service support for union types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completions kind, Quick Info, go to def, and find all refss