FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

.NET: add AgentSession StateBag edge case coverage by challaravinath · Pull Request #5838 · microsoft/agent-framework · GitHub

  1. microsoft
  2. agent-framework

Repository navigation

.NET: add AgentSession StateBag edge case coverage - #5838

Merged
Roger Barreto (rogerbarreto) merged 1 commit into
microsoft:mainfrom
challaravinath:challaravinath-agentsession-tests
May 15, 2026
ConversationCommits (1)ChecksFiles changed
Merged

.NET: add AgentSession StateBag edge case coverage#5838
Roger Barreto (rogerbarreto) merged 1 commit into
microsoft:mainfrom
challaravinath:challaravinath-agentsession-tests

Conversation

Challa Ravi (challaravinath) commented May 14, 2026

Copy link
Copy Markdown
Contributor

Motivation and Context

AgentSession.StateBag had only one existing test covering a basic set/get roundtrip.
Edge cases such as empty initial state, independent multi-key storage, and value overwrite behavior were not tested through the AgentSession layer, even though they are critical for session state correctness.

Description

  • Add test to verify AgentSession.StateBag is empty on initialization
  • Add test to verify multiple keys store and retrieve independently without interference
  • Add test to verify overwriting an existing key returns the updated value

Contribution Checklist

  • The code builds clean without any errors or warnings
  • The PR follows the Contribution Guidelines
  • All unit tests pass, and I have added new tests where possible
  • dotnet test — 1141 tests, 0 failed
  • Is this a breaking change? No — this PR only adds new tests, no production code was modified.

Copilot AI review requested due to automatic review settings May 14, 2026 04:40
Evan Mattson (moonbox3) added the .NET Usage: [Issues, PRs], Target: .Net label May 14, 2026
github-actions Bot changed the title add AgentSession StateBag edge case coverage .NET: add AgentSession StateBag edge case coverage May 14, 2026
Copilot AI reviewed May 14, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull request overview

Adds three unit tests to cover previously untested edge cases of AgentSession.StateBag: default-empty state, independent multi-key storage, and value overwriting.

Changes:

  • Add StateBag_Default_IsEmpty test
  • Add StateBag_MultipleKeys_StoreAndRetrieveIndependently test
  • Add StateBag_OverwriteValue_ReturnsUpdatedValue test

Challa Ravi (challaravinath) commented May 14, 2026

Copy link
Copy Markdown
Contributor Author

Challa Ravi (@challaravinath) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

Roger Barreto (rogerbarreto) added this pull request to the merge queue May 15, 2026
Merged via the queue into microsoft:main with commit d81a875 May 15, 2026
32 of 33 checks passed
This was referenced Jun 4, 2026
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Closed
Closed
Closed
This was referenced Jun 11, 2026
Open
Open
Closed
Closed
Closed
Closed
Closed
This was referenced Jun 24, 2026
Closed
Closed
Open
Closed
Closed
This was referenced Jul 1, 2026
Closed
Closed
Closed
Closed
This was referenced Jul 8, 2026
Closed
Closed
Open
Closed
dependabot Bot mentioned this pull request Jul 26, 2026
Merged
This was referenced Aug 26, 2026
Closed
Closed
dependabot Bot mentioned this pull request Sep 10, 2026
Closed
This was referenced Sep 19, 2026
Closed
Open
Open

This branch was previously deployed

1 inactive deployment
integration — 7cb7457e Deployed May 14, 2026 by challaravinath via dotnet-test (net472, windows-latest, Release, true, integration) #18817
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
Roger Barreto (rogerbarreto) rogerbarreto approved these changes
+1 more reviewer
Jacob Alber (lokitoth) lokitoth approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

.NET Usage: [Issues, PRs], Target: .Net

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL