Repository navigation
.NET: Fix bug in store-false helper to ensure addition rather than replacement - #5895
Merged
westey (westey-m) merged 2 commits intoMay 15, 2026
Merged
westey (westey-m) merged 2 commits into
westey (westey-m) merged 2 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
westey (westey-m)
temporarily deployed
to
integration
May 15, 2026 13:08 — with 
GitHub Actions
Inactive
westey (westey-m)
temporarily deployed
to
integration
May 15, 2026 13:08 — with
GitHub Actions
Inactive
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes ResponsesClient.AsIChatClientWithStoredOutputDisabled so it augments an existing RawRepresentationFactory instead of replacing it, matching the Project client behavior.
Changes:
- Preserve and wrap existing CreateResponseOptions factories while forcing StoredOutputEnabled = false.
- Add regression tests for preserving existing included properties and avoiding duplicate ReasoningEncryptedContent.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| dotnet/src/Microsoft.Agents.AI.OpenAI/Extensions/OpenAIResponseClientExtensions.cs | Updates the OpenAI Responses helper to chain an existing raw representation factory. |
| dotnet/tests/Microsoft.Agents.AI.OpenAI.UnitTests/Extensions/OpenAIResponseClientExtensionsTests.cs | Adds OpenAI regression tests for raw factory preservation and duplicate prevention. |
| dotnet/tests/Microsoft.Agents.AI.Foundry.UnitTests/ProjectResponsesClientExtensionsTests.cs | Adds matching Foundry/Project regression coverage for existing behavior. |
Sorry, something went wrong.
Comment thread
...tests/Microsoft.Agents.AI.OpenAI.UnitTests/Extensions/OpenAIResponseClientExtensionsTests.cs
Outdated
Comment thread
dotnet/tests/Microsoft.Agents.AI.Foundry.UnitTests/ProjectResponsesClientExtensionsTests.cs
Outdated
westey (westey-m)
had a problem deploying
to
integration
May 15, 2026 14:11 — with
GitHub Actions
Failure
westey (westey-m)
temporarily deployed
to
integration
May 15, 2026 14:11 — with
GitHub Actions
Inactive
SergeyMenshykh
approved these changes
May 15, 2026
westey (westey-m)
temporarily deployed
to
integration
May 15, 2026 14:54 — with
GitHub Actions
Inactive
Jacob Alber (lokitoth)
approved these changes
May 15, 2026
westey (westey-m)
enabled auto-merge
May 15, 2026 15:10
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
May 15, 2026
This was referenced Jun 4, 2026
This was referenced Jun 10, 2026
This was referenced Jun 17, 2026
This was referenced Jun 24, 2026
This was referenced Jul 1, 2026
This was referenced Aug 26, 2026
This was referenced Sep 19, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Currently using AsIChatClientWithStoredOutputDisabled causes any other raw representation factory to be ignored when using the ResponsesClient. However when using the ProjectClient, it appends, which is the correct behavior.
Description
Contribution Checklist