Automated Code Review

Reviewers: 4 | Confidence: 85%

✓ Correctness

No actionable issues found in this dimension.

✓ Security Reliability

No actionable issues found in this dimension.

✓ Test Coverage

The BackgroundAgents rename is thoroughly tested across all tool name references and instruction strings. For the TodoProvider changes, existing tests are updated to use the new TodoCompleteInput type and a new test verifies the Reason parameter is accepted. However, the new CompleteTodos_AcceptsReasonParameterAsync test only asserts that the item is marked complete and the count is correct—it does not verify that the provided Reason is actually used or surfaced in any output, which is a gap given the PR states the reason is meant to 'improve user output'. Since TodoItem.cs is not in the changed file list, the Reason appears not to be stored on the model, making the observable impact of the Reason field untested.

✓ Design Approach

First, the SubAgents→BackgroundAgents rename also changes the persisted state keys, so any existing session that already has queued/running sub-agent work will be treated as empty after upgrade instead of being recoverable or marked lost. Second, the new Todo completion shape does not actually require a completion reason: the new input model makes reason nullable and the handler ignores it entirely, so calls without a reason still succeed despite the new contract text. I found two design mismatches in the updated tests. First, the TodoList completion flow is still being specified as succeeding without any finish reason, which conflicts with the PR’s stated goal of requiring one. Second, the BackgroundAgents rename appears incomplete on the custom-instructions surface: the tests still use the old {sub_agents} placeholder, which would leave {background_agents} callers with an unreplaced literal unless the provider supports both tokens.

Automated review by westey-m's agents

Pull request overview

This PR updates the .NET Harness to (1) rename “SubAgents” to “BackgroundAgents” to better reflect asynchronous background execution, and (2) extend Todo completion calls to include an optional “reason” payload for improved UI output.

Changes:

• Renames SubAgents provider/types/tool names to BackgroundAgents across src, tests, and samples.
• Changes TodoList_Complete input shape from ids to items[] (with optional reason) and updates tests/JSON source-gen registration accordingly.
• Updates Harness sample Step02 and console tool formatters to reflect the new names and richer Todo completion formatting.

Reviewed changes

Copilot reviewed 18 out of 19 changed files in this pull request and generated 3 comments.

dotnet/src/Microsoft.Agents.AI/Harness/BackgroundAgents/BackgroundAgentsProvider.cs:40

• This change renames/removes the public SubAgentsProvider API (and tool names) in favor of BackgroundAgentsProvider, which is a breaking change for any consumers. Please either preserve backward compatibility (e.g., keep SubAgentsProvider/old tool names as [Obsolete] shims) or mark the PR as breaking (title/release notes) so downstream users can migrate deliberately.
  dotnet/src/Microsoft.Agents.AI/Harness/BackgroundAgents/BackgroundAgentsProviderOptions.cs:22
• The instructions/template placeholder is still named {sub_agents} even though the feature has been renamed to BackgroundAgents. This is likely to confuse users authoring custom instructions. Consider supporting a {background_agents} placeholder (while still honoring {sub_agents} for compatibility), and update the docs/comments accordingly.