Repository navigation
.NET: Add A2AAgentOptions and align A2AAgent constructors with ChatClientAgent pattern - #5954
Merged
SergeyMenshykh merged 2 commits intoMay 20, 2026
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
…ientAgent pattern Adds a new A2AAgentOptions class (Id, Name, Description, Clone) and an options-based constructor on A2AAgent, mirroring ChatClientAgent/ChatClientAgentOptions. The existing parameter-based constructor is preserved for backward compatibility and now delegates to the options-based one. Extension methods are extended with options-based overloads: - A2AClientExtensions.AsAIAgent(IA2AClient, A2AAgentOptions, ...) - A2AAgentCardExtensions.AsAIAgent(AgentCard, A2AAgentOptions, ...) - A2ACardResolverExtensions.GetAIAgentAsync(A2ACardResolver, A2AAgentOptions, ...) For card-based creation, user-supplied options override values from the agent card; Name and Description fall back to card values when not set. Options are cloned when stored on the agent to prevent post-construction mutation, matching the ChatClientAgent pattern. Resolves microsoft#5870. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
SergeyMenshykh
temporarily deployed
to
integration
May 19, 2026 15:00 — with 
GitHub Actions
Inactive
SergeyMenshykh
temporarily deployed
to
integration
May 19, 2026 15:00 — with
GitHub Actions
Inactive
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds an A2AAgentOptions type and updates A2AAgent/extension method creation paths to use an options-based construction pattern (matching ChatClientAgentOptions), enabling callers to override agent Id/Name/Description during agent creation (including card-based flows).
Changes:
- Introduces A2AAgentOptions (Id/Name/Description + Clone()), and adds an options-based A2AAgent constructor that clones options to prevent post-construction mutation.
- Adds options-based overloads for AsAIAgent(...) and GetAIAgentAsync(...) and merges options with card values (fallback to card Name/Description).
- Adds unit tests validating overrides, fallbacks, null handling, and mutation isolation.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file| File | Description |
|---|---|
| dotnet/src/Microsoft.Agents.AI.A2A/A2AAgentOptions.cs | New options object to carry agent identity fields and support cloning. |
| dotnet/src/Microsoft.Agents.AI.A2A/A2AAgent.cs | Adds options-based constructor + stores cloned options for immutability. |
| dotnet/src/Microsoft.Agents.AI.A2A/Extensions/A2AClientExtensions.cs | Adds AsAIAgent(..., A2AAgentOptions, ...) overload. |
| dotnet/src/Microsoft.Agents.AI.A2A/Extensions/A2ACardResolverExtensions.cs | Adds GetAIAgentAsync(..., A2AAgentOptions, ...) overload. |
| dotnet/src/Microsoft.Agents.AI.A2A/Extensions/A2AAgentCardExtensions.cs | Adds AsAIAgent(..., A2AAgentOptions, ...) overload with merge behavior. |
| dotnet/tests/.../A2AAgentTests.cs | Adds tests for options ctor, null handling, and mutation isolation. |
| dotnet/tests/.../Extensions/A2AClientExtensionsTests.cs | Adds tests for options-based agent creation from a client. |
| dotnet/tests/.../Extensions/A2ACardResolverExtensionsTests.cs | Adds tests for card resolver creation with override + fallback behavior. |
| dotnet/tests/.../Extensions/A2AAgentCardExtensionsTests.cs | Adds tests for card-based creation with override + fallback behavior. |
Sorry, something went wrong.
Comment thread
dotnet/tests/Microsoft.Agents.AI.A2A.UnitTests/Extensions/A2AClientExtensionsTests.cs
Outdated
Comment thread
dotnet/tests/Microsoft.Agents.AI.A2A.UnitTests/Extensions/A2AClientExtensionsTests.cs
Outdated
- Add Throw.IfNull(client) in A2AClientExtensions.AsAIAgent - Add Throw.IfNull(card) in A2AAgentCardExtensions.AsAIAgent - Clarify httpClient docs in A2ACardResolverExtensions.GetAIAgentAsync: it applies to the created A2A client, not to card discovery - Rename test methods from GetAIAgent_* to AsAIAgent_* to match the API under test Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
SergeyMenshykh
temporarily deployed
to
integration
May 19, 2026 15:49 — with
GitHub Actions
Inactive
SergeyMenshykh
temporarily deployed
to
integration
May 19, 2026 15:49 — with
GitHub Actions
Inactive
SergeyMenshykh
marked this pull request as ready for review
May 19, 2026 17:40
SergeyMenshykh
enabled auto-merge
May 19, 2026 17:40
westey (westey-m)
approved these changes
May 20, 2026
Roger Barreto (rogerbarreto)
approved these changes
May 20, 2026
This was referenced Jun 4, 2026
This was referenced Jun 6, 2026
This was referenced Jun 17, 2026
This was referenced Jun 24, 2026
This was referenced Jul 1, 2026
This was referenced Aug 26, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5870.
Adds a new A2AAgentOptions class (Id, Name, Description) and options-based overloads on A2AAgent and the AsAIAgent / GetAIAgentAsync extension methods, mirroring the ChatClientAgent / ChatClientAgentOptions pattern.
This enables callers to supply a custom agent Id / Name / Description when creating an agent via A2ACardResolver.GetAIAgentAsync or AgentCard.AsAIAgent. For card-based creation, user-supplied values override the card; Name and Description fall back to card values when not set.
All existing public APIs are preserved.