FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

.NET: Fix release build analyzer failures by SergeyMenshykh · Pull Request #7721 · microsoft/agent-framework · GitHub

  1. microsoft
  2. agent-framework

Repository navigation

.NET: Fix release build analyzer failures - #7721

Merged
SergeyMenshykh merged 2 commits into
microsoft:mainfrom
SergeyMenshykh:sergeymenshykh-fix-release-build
Aug 18, 2026
ConversationCommits (2)ChecksFiles changed
Merged

.NET: Fix release build analyzer failures#7721
SergeyMenshykh merged 2 commits into
microsoft:mainfrom
SergeyMenshykh:sergeymenshykh-fix-release-build

Conversation

SergeyMenshykh commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Motivation & Context

The .NET release solution build is blocked by CA1873 in Foundry Hosting and by a net9 ILLink analyzer crash when C# 14 extension members are analyzed under SDK 10.0.302. This restores release builds without suppressing diagnostics or changing the public API.

Description & Review Guide

  • What are the major changes? Guard the hosted-storage error log with ILogger.IsEnabled(LogLevel.Error) before evaluating agent.Name, and update the SDK pin from 10.0.302 to the servicing release 10.0.303.
  • What is the impact of these changes? Release analysis no longer reports CA1873, and net9 builds use the serviced ILLink analyzer that handles C# 14 extension members without throwing AD0001.
  • What do you want reviewers to focus on? Confirm that 10.0.303 is the preferred minimal SDK servicing baseline and that the logging guard is appropriately scoped.

Related Issue

Fixes #7720

Contribution Checklist

  • The code builds clean without any errors or warnings
  • All unit tests pass, and I have added new tests where possible
  • The PR follows the Contribution Guidelines
  • This PR is linked to an issue and there is no other open PR for this issue (see Related Issue above).
  • This is not a breaking change. If it is a breaking change, add the breaking change label (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.

.NET: Fix release build analyzer failures
fadc633 
Guard the hosted storage error log before evaluating the agent name and update the SDK to the servicing release containing the net9 ILLink analyzer fix.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: e3a6cce8-e1e8-4cf2-9cf4-3c0c8f3ed6d8
Copilot AI balanced review requested due to automatic review settings August 18, 2026 12:15
agent-framework-automation Bot added the .NET Usage: [Issues, PRs], Target: .Net label Aug 18, 2026
SergeyMenshykh marked this pull request as ready for review August 18, 2026 12:18
Copilot AI reviewed Aug 18, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull request overview

Restores .NET release builds by addressing the logging analyzer warning and upgrading the SDK servicing baseline.

Changes:

  • Guards error-log argument evaluation with IsEnabled.
  • Updates the .NET SDK pin to 10.0.303.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
dotnet/src/Microsoft.Agents.AI.Foundry.Hosting/AgentFrameworkResponseHandler.cs Prevents unnecessary agent.Name evaluation when error logging is disabled.
dotnet/global.json Pins SDK 10.0.303 to obtain the serviced analyzer.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

github-actions Bot reviewed Aug 18, 2026
View reviewed changes

github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

MAF Automated Review — Iteration 1

Result: No findings
Scope: full PR (1 commit(s)): fadc6331d30f
Model: gpt-5.6-sol

Overview

The PR updates the pinned .NET SDK to the servicing release and prevents evaluation of agent.Name when error logging is disabled. The logging guard is narrowly scoped, while the storage-misconfiguration detection, cleanup, persistence safeguards, and unconditional 501 exception remain intact. Existing tests cover the disabled-logger failure path and stable error contract, and no publishable risk was established.

Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
No publishable findings remained after source verification for this scope.

SergeyMenshykh added this pull request to the merge queue Aug 18, 2026
Merged via the queue into microsoft:main with commit 4ce2804 Aug 18, 2026
25 checks passed
This was referenced Aug 18, 2026
Closed
Closed
Merged
Merged
This was referenced Sep 23, 2026
Merged
Closed
Closed
Closed
Open
Closed
Open
Closed
Closed
Closed
Open
Closed
Closed
Closed
Open
Open
Closed
This was referenced Oct 1, 2026
Open
Open
Closed
Closed
Open
Open
Merged
Closed
Open
Closed
Open
Open
Open

This branch was previously deployed

2 inactive deployments
integration — 73b9c961 Deployed Aug 18, 2026 by SergeyMenshykh via dotnet-test (net472, windows-latest, Release, true, integration) #25158
github-app-auth — 73b9c961 Deployed Aug 18, 2026 by SergeyMenshykh via add_label #20812
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

github-actions[bot] github-actions[bot] left review comments
Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
westey (westey-m) westey-m approved these changes
chetantoshniwal Awaiting requested review from chetantoshniwal
Roger Barreto (rogerbarreto) Awaiting requested review from rogerbarreto rogerbarreto is a code owner
Peter Ibekwe (peibekwe) Awaiting requested review from peibekwe peibekwe is a code owner

Assignees

No one assigned

Labels

.NET Usage: [Issues, PRs], Target: .Net

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

.NET: Release build fails on CA1873 and net9 ILLink analyzer crash

3 participants

Back | FazBrowse Home | New Git URL