@microsoft-github-policy-service agree

Esan (@EsanRAHIMI) You are right; the broader date/time conversion was not intentional. Addressed in 60d9e33 by moving (datetime, date, time) conversion back into the dictionary-value branch. Top-level date/time attributes and date/time list items are skipped as before, while dictionary values still serialize to strings and the nested protocol recursion remains intact. The regression test now covers all three date/time types in top-level, list-item, and dictionary-value locations. The 485 serialization/session/type tests, Ruff, source Pyright, and test Pyright all pass.

Evan Mattson (@moonbox3) The follow-up in 8f3b8be addresses both remaining compatibility concerns: nested non-string dictionary keys retain the previous to_dict()/to_json() behavior, and recursive list/dictionary cycles now raise the controlled ValueError while repeated acyclic references remain supported. Regression tests cover both paths, and all 507 relevant tests plus Ruff and Pyright pass locally. A fresh review of the latest commit would be appreciated when convenient.

Python Unit Test Overview

Thanks for the suggestion! _SKIP_SERIALIZATION is already defined as a module-level object() sentinel, and all checks use identity comparison with is. If you meant a named sentinel type or a different project convention, I’m happy to adjust it.

Thanks for the clarification. Updated _SKIP_SERIALIZATION to use the project-standard typing_extensions.Sentinel("SKIP_SERIALIZATION") with a Final annotation, while keeping the existing identity checks and behavior unchanged.

The focused serialization tests (39 tests) and Ruff check/format pass locally. The full dependency Pyright run is currently blocked by unrelated missing optional modules in this checkout.