| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
@microsoft-github-policy-service agree |
Sorry, something went wrong.
There was a problem hiding this comment.
Reviewed current head aab491a. Using inspect.isawaitable() is the correct contract-level check here: it includes coroutine objects, asyncio.Task, and Future, while the unchanged __aiter__ branch preserves async-iterable precedence for hybrid sources. The parameterized tests exercise all three awaitable forms through both the constructor and from_awaitable(), including iteration and finalization. I found no blocking issue in the scoped diff.
The repository's full Python workflows have not run on this external branch yet, so this approval is based on the current code/tests plus the author's reported focused 312-test and type-checker runs, not a claim that upstream CI is complete.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Motivation & Context
Scheduling stream initialization with asyncio.create_task() currently breaks ResponseStream, even though its input accepts an awaitable. Task and Future sources are treated as iterators instead of being awaited, so callers get an AttributeError during iteration or RuntimeError: Inner stream not available during finalization.
Description & Review Guide
Related Issue
Fixes #8330
Contribution Checklist