FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

.NET: Preserve cached and reasoning token counts in Foundry Hosting by manjunathshiva · Pull Request #8334 · microsoft/agent-framework · GitHub

  1. microsoft
  2. agent-framework

Repository navigation

.NET: Preserve cached and reasoning token counts in Foundry Hosting - #8334

Merged
Vincent Biret (baywet) merged 1 commit into
microsoft:mainfrom
manjunathshiva:fix/6823-foundry-usage-counters
Sep 15, 2026
ConversationCommits (1)ChecksFiles changed
Merged

.NET: Preserve cached and reasoning token counts in Foundry Hosting#8334
Vincent Biret (baywet) merged 1 commit into
microsoft:mainfrom
manjunathshiva:fix/6823-foundry-usage-counters

Conversation

Manjunath Janardhan (manjunathshiva) commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Motivation & Context

Foundry Hosting reports cached input and reasoning tokens as zero when providers populate the dedicated UsageDetails properties. For example, CachedInputTokenCount = 34304 and ReasoningTokenCount = 128 become zero in the completed response, while input/output/total counts remain correct.

Description & Review Guide

  • What are the major changes? Read CachedInputTokenCount and ReasoningTokenCount first, falling back to each existing AdditionalCounts key only when the dedicated property is absent. Add nine regression cases covering missing values, explicit zero, conflicting and mixed representations, and accumulation into completed and failed responses.
  • What is the impact of these changes? Foundry response usage preserves the provider's cached/reasoning counts. Legacy dictionary-only callers retain their behavior. No public API or response-schema changes.
  • What do you want reviewers to focus on? The per-counter fallback and precedence rules, especially explicit zero and avoiding double counting.

Verified with .NET SDK 10.0.401 on macOS arm64: seven regression cases failed before the fix; all nine pass afterward. All 473 Foundry Hosting tests pass. The full solution builds with zero warnings/errors; the enabled .NET 10 Debug unit suite passes 7,322 tests with 65 skipped and no failures, preserving the solution's existing Feature Registry Debug exclusion. Formatting checks pass. Reproduction uses the actual in-process converter; no live Azure/model calls were required.

Related Issue

Fixes #6823

Contribution Checklist

  • The code builds clean without any errors or warnings
  • All unit tests pass, and I have added new tests where possible
  • The PR follows the Contribution Guidelines
  • This PR is linked to an issue and there is no other open PR for this issue (see Related Issue above).
  • This is not a breaking change. If it is a breaking change, add the breaking change label (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.

Copilot AI balanced review requested due to automatic review settings September 12, 2026 17:30
agent-framework-automation Bot added the .NET Usage: [Issues, PRs], Target: .Net label Sep 12, 2026
Copilot AI reviewed Sep 12, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

🟢 Approval recommended

The focused implementation correctly preserves compatibility and is comprehensively covered by regression tests.

Pull request overview

Fixes #6823 by preserving provider-reported cached-input and reasoning-token counts in Foundry Hosting.

Changes:

  • Prefer dedicated usage counters while retaining legacy dictionary fallbacks.
  • Add regression coverage for precedence, explicit zeroes, fallback, and terminal-event accumulation.
File summaries
File Description
dotnet/src/Microsoft.Agents.AI.Foundry.Hosting/OutputConverter.cs Corrects usage-counter conversion and fallback behavior.
dotnet/tests/Microsoft.Agents.AI.Foundry.Hosting.UnitTests/OutputConverterTests.cs Covers counter representations, precedence, and accumulation.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Balanced (auto)

Note

Copilot is running an experiment and ran this review at Balanced.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Manjunath Janardhan (manjunathshiva) marked this pull request as ready for review September 12, 2026 17:32
Vincent Biret (baywet) approved these changes Sep 15, 2026
View reviewed changes

Vincent Biret (baywet) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the contribution!

Vincent Biret (baywet) added this pull request to the merge queue Sep 15, 2026
Merged via the queue into microsoft:main with commit 6c3c58a Sep 15, 2026
38 checks passed
This was referenced Sep 18, 2026
Closed
Closed
Closed
Closed
Closed
This was referenced Sep 30, 2026
Open
Open
Closed
Closed
Open
Merged
Open
Closed
Closed
Open
Open
Merged
Open
Open
Open
Open
Open
Closed
Open
Open
Open
Closed
Open
Open
Open
Open
Closed
Open
Closed
Open

This branch was successfully deployed

2 active deployments
integration — a7fb68c3 Deployed Sep 15, 2026 by manjunathshiva via dotnet-test (net10.0, ubuntu-latest, Release, true, integration) #27206
github-app-auth — a7fb68c3 Deployed Sep 12, 2026 by manjunathshiva via team_check #4197
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
Vincent Biret (baywet) baywet approved these changes
Eduard van Valkenburg (eavanvalkenburg) Awaiting requested review from eavanvalkenburg eavanvalkenburg is a code owner
SergeyMenshykh Awaiting requested review from SergeyMenshykh SergeyMenshykh is a code owner
Roger Barreto (rogerbarreto) Awaiting requested review from rogerbarreto rogerbarreto is a code owner
westey (westey-m) Awaiting requested review from westey-m westey-m is a code owner
Evan Mattson (moonbox3) Awaiting requested review from moonbox3 moonbox3 is a code owner
Peter Ibekwe (peibekwe) Awaiting requested review from peibekwe peibekwe is a code owner

Assignees

No one assigned

Labels

.NET Usage: [Issues, PRs], Target: .Net

Projects

None yet

Milestone

No milestone

3 participants

Back | FazBrowse Home | New Git URL