| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
There was a problem hiding this comment.
The new overload makes existing positional default-literal calls ambiguous, creating an unintended source-breaking change.
Get a fresh assessment by requesting another Copilot review.
Pull request overviewAdds independent controls for AgentModeProvider tools while retaining mode state, guidance, and notifications.
Changes:
| File | Description |
|---|---|
| AgentModeProvider.cs | Implements tool controls, guidance, and notification suppression. |
| AgentModeProviderOptions.cs | Adds tool-disable options. |
| AgentModeProviderTests.cs | Tests exposure combinations and notifications. |
| PublicAPI/net10.0/PublicAPI.Unshipped.txt | Records new net10.0 APIs. |
| PublicAPI/net9.0/PublicAPI.Unshipped.txt | Records new net9.0 APIs. |
| PublicAPI/net8.0/PublicAPI.Unshipped.txt | Records new net8.0 APIs. |
| PublicAPI/netstandard2.0/PublicAPI.Unshipped.txt | Records new netstandard2.0 APIs. |
| PublicAPI/net472/PublicAPI.Unshipped.txt | Records new net472 APIs. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
There was a problem hiding this comment.
Result: Findings reported
Scope: full PR (1 commit(s)): 6589bafa15b7
Model: gpt-5.6-sol-fast
The .NET implementation independently gates both built-in tools, updates only default guidance, and preserves mode state and notification behavior; the added tests cover all exposure combinations and stale-notification suppression. One source-compatibility gap remains: the new Boolean overload makes an existing positional default cancellation-token call ambiguous at compile time.
Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
1 verified finding remained after source verification (1 medium) across 1 file. Details are attached to the affected lines below.
Affected areas: dotnet/src/Microsoft.Agents.AI/Harness/AgentMode/AgentModeProvider.cs
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Motivation & Context
Applications can retain AgentModeProvider state and workflow guidance while supplying their own mode-change UI or function tool, but the .NET provider currently always exposes both mode_set and mode_get. This gives the model duplicate mode authorities when an application provides a replacement setter.
This change allows each built-in mode tool to be disabled independently without disabling mode state, per-turn instructions, helper APIs, or external mode-change notifications. Replacement function tools can reuse SetModeAsync while suppressing redundant notifications already conveyed through the tool result.
Description & Review Guide
Related Issue
Related to #7221. This is the .NET counterpart to #8450, which implemented the Python behavior and closed the original issue. No separate open .NET issue or duplicate PR was found.
Contribution Checklist