🟢 Approval recommended

The documentation accurately reflects the caching implementation and introduces no runtime changes.

Clarifies the existing default cache scope and isolation requirements for .NET Agent Skills providers.

Changes:

• Documents shared-cache behavior for custom sources and Build().
• Explains when to use isolation keys or disable caching.

• Files reviewed: 2/2 changed files
• Comments generated: 0
• Review effort level: Balanced

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

MAF Automated Review — Iteration 1

Result: Findings reported
Scope: full PR (1 commit(s)): 4e1fc1beb6c1
Model: gpt-5.6-sol-fast

Overview

The added XML documentation correctly surfaces the builder's default caching, the null-key shared bucket, and the available opt-out and isolation controls. The implementation and tests substantiate default reuse, per-key separation, retries after failures or cancellation, and provider-owned cache disposal. One uncommon but concrete isolation gap remains: the internal shared-bucket sentinel is an ordinary string that a non-null selector can return, so the new security-boundary guidance overstates the isolation guarantee for that value.

Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
1 verified finding remained after source verification (1 medium) across 1 file. Details are attached to the affected lines below.

Affected areas: dotnet/src/Microsoft.Agents.AI/Skills/Decorators/CachingAgentSkillsSourceOptions.cs