FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Test and mark Python 3.12 support. Update setuptools support for >67 by tonybaloney · Pull Request #469 · microsoft/azure-devops-python-api · GitHub

/ azure-devops-python-api Public

Test and mark Python 3.12 support. Update setuptools support for >67 - #469

Merged
Petr Nechvátal (nechvatalp) merged 3 commits into
microsoft:devfrom
tonybaloney:flag_312
Nov 20, 2023
ConversationCommits (3)ChecksFiles changed
Merged

Test and mark Python 3.12 support. Update setuptools support for >67#469
Petr Nechvátal (nechvatalp) merged 3 commits into
microsoft:devfrom
tonybaloney:flag_312

Conversation

Anthony Shaw (tonybaloney) commented Oct 6, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This package is broken in the latest version of setuptools, this PR fixes the issue and tests the patch on Python 3.12

Anthony Shaw (tonybaloney) changed the title Test and mark Python 3.12 support Test and mark Python 3.12 support. Update setuptools support for >67 Oct 6, 2023
Anthony Shaw (tonybaloney) marked this pull request as draft October 7, 2023 00:06
Remove the __init__ and use namespace packages to fix the issue with …
87c3dde 
…the clash of azure.core namespace from the msrest package
Anthony Shaw (tonybaloney) marked this pull request as ready for review October 11, 2023 02:27
Anthony Shaw (tonybaloney) mentioned this pull request Oct 11, 2023
Closed
Remy Jette (remyjette) mentioned this pull request Oct 11, 2023
Closed
Stefan J. Wernli (swernli) added a commit to microsoft/qdk that referenced this pull request Oct 11, 2023
Update to Rust 1.73, improve devcontainer
bf2c6aa 
This change updates the build scripts and yaml to use Rust 1.73, which introduced some new clippy lints that the code was in violation of. The changes have the version update and the code updates for compatibility, and to keep the new clippy lints in check the minimum required version is updated in prereqs.py.

This also updates the devcontainer definition to include the Azure CLI and fixes the Python version to 3.11 (3.12 was releast on Oct 3, 2023 and does not yet play nice with azure-cli packages, see microsoft/azure-devops-python-api#469).
Stefan J. Wernli (swernli) mentioned this pull request Oct 11, 2023
Merged

Jonathan Myers (jmyersmsft) commented Oct 18, 2023

Copy link
Copy Markdown
Member

Petr Nechvátal (@nechvatalp) Can you review this? Looks like there are very few others who have permission.

Steve Dower (zooba) commented Oct 26, 2023

Copy link
Copy Markdown
Member

Petr Nechvátal (@nechvatalp) Any chance of a review?

cmollgaard commented Nov 15, 2023

Copy link
Copy Markdown

A review would be very helpful.
The PR seems to fix the problems with namespace in our 3.9 and 3.10 environments

Jonathan Myers (jmyersmsft) commented Nov 15, 2023

Copy link
Copy Markdown
Member

Pinging some other folks who might be able to help: Sarah Kaiser (@crazy4pi314) Matt Cooper (@vtbassmatt) Ted Chambers (@tedchamb)

Matt Cooper (vtbassmatt) commented Nov 15, 2023

Copy link
Copy Markdown
Member

I haven't worked on this product in years, and wouldn't be comfortable approving a PR.

Sarah Kaiser (crazy4pi314) reviewed Nov 15, 2023
View reviewed changes

Sarah Kaiser (crazy4pi314) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good to me! Easy 3.12 upgrade party 🥳

Petr Nechvátal (nechvatalp) commented Nov 20, 2023

Copy link
Copy Markdown
Collaborator

Looks good to me, thanks for your contribution

Petr Nechvátal (nechvatalp) merged commit 32e705f into microsoft:dev Nov 20, 2023
Petr Nechvátal (nechvatalp) added a commit that referenced this pull request Jul 26, 2024
Merge pull request #469 from tonybaloney/flag_312
b603def 
Test and mark Python 3.12 support. Update setuptools support for >67
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Sarah Kaiser (crazy4pi314) crazy4pi314 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL