FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[Samples] Add 11.qnamaker bot sample by Batta32 · Pull Request #1023 · microsoft/botbuilder-java · GitHub

This repository was archived by the owner on Dec 4, 2023. It is now read-only.
/ botbuilder-java Public archive

[Samples] Add 11.qnamaker bot sample - #1023

Merged
tracyboehrer (tracyboehrer) merged 13 commits into
microsoft:mainfrom
southworks:feature/southworks/samples/11qnamaker
Feb 26, 2021
ConversationCommits (13)ChecksFiles changed
Merged

[Samples] Add 11.qnamaker bot sample#1023
tracyboehrer (tracyboehrer) merged 13 commits into
microsoft:mainfrom
southworks:feature/southworks/samples/11qnamaker

Conversation

Martin Battaglino (Batta32) commented Feb 26, 2021

Copy link
Copy Markdown
Contributor

Fixes #864

Description

We are adding the sample 11.qnamaker in Java taking into account the C# 11.qnamaker bot present in BotBuilder-Samples repository.

Specific Changes

  • Generate main structure of the sample
  • Add resources folder with sample questions tsv
  • Add deploymentTemplates folder
  • Add root files
  • Add application.properties
  • Add LICENSE document
  • Add README document to describe the steps to run the sample

Testing

Current behavior of the Java migrated sample

MatR (matiasroldan6) and others added 11 commits February 19, 2021 13:57
tracyboehrer (tracyboehrer) suggested changes Feb 26, 2021
View reviewed changes
Comment thread samples/11.qnamaker/src/main/java/com/microsoft/bot/sample/qnamaker/QnABot.java Outdated
};

// The actual call to the QnA Maker service.
qnaMaker.getAnswers(turnContext, options).thenAccept(response -> {

tracyboehrer (tracyboehrer) Feb 26, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This should be:

        // The actual call to the QnA Maker service.
        return qnaMaker.getAnswers(turnContext, options)
            .thenCompose(response -> {
                if (response != null && response.length > 0) {
                    return turnContext.sendActivity(MessageFactory.text(response[0].getAnswer()))
                        .thenApply(sendResult -> null);
                }
                else {
                    return turnContext.sendActivity(MessageFactory.text("No QnA Maker answers were found."))
                        .thenApply(sendResult -> null);
                }
            });

Comment thread samples/11.qnamaker/deploymentTemplates/new-rg-parameters.json Outdated
@@ -0,0 +1,42 @@
{

tracyboehrer (tracyboehrer) Feb 26, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

new-rg-parameters.json can be removed.

Comment thread samples/11.qnamaker/deploymentTemplates/preexisting-rg-parameters.json Outdated
@@ -0,0 +1,39 @@
{

tracyboehrer (tracyboehrer) Feb 26, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

preexisting-rg-parameters.json can be removed.

Comment thread samples/11.qnamaker/deploymentTemplates/template-with-new-rg.json
@@ -0,0 +1,183 @@
{

tracyboehrer (tracyboehrer) Feb 26, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Update template-with-new-rg.json with version from 02.echo-bot

Comment thread samples/11.qnamaker/deploymentTemplates/template-with-preexisting-rg.json
@@ -0,0 +1,154 @@
{

tracyboehrer (tracyboehrer) Feb 26, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Update template-with-preexisting-rg.json with version from 02.echo-bot

tracyboehrer (tracyboehrer) commented Feb 26, 2021

Copy link
Copy Markdown
Member

Martin Battaglino (@Batta32) Also need to update from main

Martin Battaglino (Batta32) commented Feb 26, 2021

Copy link
Copy Markdown
Contributor Author

Thanks tracyboehrer (@tracyboehrer) for your feedback. We will be applying the requested changes right now!

MatR (matiasroldan6) added a commit to southworks/botbuilder-java that referenced this pull request Feb 26, 2021
Add changes requested from PR microsoft#1023
80b8cc7

Martin Battaglino (Batta32) commented Feb 26, 2021

Copy link
Copy Markdown
Contributor Author

tracyboehrer (@tracyboehrer) - we already applied the requested changes and merged main into this branch 😊.

tracyboehrer (tracyboehrer) merged commit f84e1da into microsoft:main Feb 26, 2021
Martin Battaglino (Batta32) deleted the feature/southworks/samples/11qnamaker branch March 1, 2021 12:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Lee Parrish (LeeParrishMSFT) Awaiting requested review from LeeParrishMSFT
1 more reviewer
tracyboehrer (tracyboehrer) tracyboehrer approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sample: 11.qnamaker

4 participants

Back | FazBrowse Home | New Git URL