This repository was archived by the owner on Dec 4, 2023. It is now read-only.
Move allowed callers and skill conversation factory to SDK - #1062
Merged
Lee Parrish (LeeParrishMSFT) merged 3 commits intoMar 17, 2021
Merged
Move allowed callers and skill conversation factory to SDK#1062Lee Parrish (LeeParrishMSFT) merged 3 commits into
Lee Parrish (LeeParrishMSFT) merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Lee Parrish (LeeParrishMSFT)
requested a review
from tracyboehrer (tracyboehrer)
March 17, 2021 14:00
tracyboehrer (tracyboehrer)
approved these changes
Mar 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1041
Description
Moved common code used in skills bots to the SDK including AllowedCallersClaimsValidator.java and SkillConversationIdFactory.java. Also ported additional unit tests for these two classes, and correct samples 80 and 81 to remove the redundant code and use these classes from the SDK.
Specific Changes
Moved AllowedCallersClaimsValidator.java and SkillConversationFactory.java, added unit test classes for each of these respectively, and updated samples 80 and 81 to use the AllowedCallersClaimsValidator and SkillConversationIdFactory that are now part of the SDK.
Testing
Unit tests all pass, and samples were run and tested.