This repository was archived by the owner on Dec 4, 2023. It is now read-only.
[SDK][Bot-Azure] Add BlobsStorage component - #1066
Merged
tracyboehrer (tracyboehrer) merged 13 commits intoMar 23, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Martin Battaglino (Batta32)
requested review from
Lee Parrish (LeeParrishMSFT) and
tracyboehrer (tracyboehrer)
March 19, 2021 14:04
Copy link
Copy Markdown
Contributor
|
Hi tracyboehrer (@tracyboehrer), the unit test for this implementation requires Azure Storage Emulator, just like the PR #1033. |
Sorry, something went wrong.
* Apply Tracy feedback * Rename afterTest to testCleanup
Copy link
Copy Markdown
Contributor
|
tracyboehrer (@tracyboehrer), we replaced the assertEmulator with runIfEmulator as requested 😊. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
tracyboehrer (@tracyboehrer), we updated this branch too and the build passed! |
Sorry, something went wrong.
tracyboehrer (tracyboehrer)
approved these changes
Mar 23, 2021
Martin Battaglino (Batta32)
deleted the
external/feature/southworks/blobstorage/base
branch
March 23, 2021 20:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #908
Description
Implements BlobsStorage class and its unit tests. This PR also fixes a few disparities with C# present in different classes. Also, it's improving the parity C# - Java adding last changes of the repository.
Specific Changes
Testing
BlobsStorageTests unit tests correctly passing
TranscriptStoreTests unit tests correctly passing
mvn clean install of the entire solution
