This repository was archived by the owner on Dec 4, 2023. It is now read-only.
[Samples & SDK] Replace Double Brace initialization with Standard Initialization - #1103
Merged
tracyboehrer (tracyboehrer) merged 27 commits intoMar 29, 2021
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Martin Battaglino (Batta32)
requested review from
Lee Parrish (LeeParrishMSFT) and
tracyboehrer (tracyboehrer)
March 26, 2021 21:40
tracyboehrer (tracyboehrer)
approved these changes
Mar 29, 2021
Martin Battaglino (Batta32)
deleted the
external/feature/southworks/double-brace/base
branch
March 29, 2021 13:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1067
Description
We replaced all the double brace initialization from samples and libraries (code + unit tests) to avoid serialization issues.
Specific Changes
Testing
We double checked the behavior of all the samples and the execution of the unit tests of each library.
Successful mvn clean install execution after changes
Successful communication of the 17.multilingual-bot sample after changes
Successful communication of the 49.qnamaker-all-features sample after changes
