This repository was archived by the owner on Dec 4, 2023. It is now read-only.
Update telemetry to log attachments - #1114
Merged
tracyboehrer (tracyboehrer) merged 2 commits intoMar 30, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Lee Parrish (LeeParrishMSFT)
requested a review
from tracyboehrer (tracyboehrer)
March 30, 2021 14:37
tracyboehrer (tracyboehrer)
approved these changes
Mar 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #437
Description
Added code to log attachments as part of the TelemetryLoggerMiddleware.
Specific Changes
Added code required to log attachments as part of the information logged if logPersonalInformation is set to true.
Testing
Added unit test to check that attachments are logged.