This repository was archived by the owner on Dec 4, 2023. It is now read-only.
Implement TeamsSSOExchangeMiddleware and fixes to associated dependency areas. - #1167
Merged
tracyboehrer (tracyboehrer) merged 3 commits intoApr 16, 2021
Merged
Implement TeamsSSOExchangeMiddleware and fixes to associated dependency areas.#1167tracyboehrer (tracyboehrer) merged 3 commits into
tracyboehrer (tracyboehrer) merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Lee Parrish (LeeParrishMSFT)
requested a review
from tracyboehrer (tracyboehrer)
April 16, 2021 00:10
tracyboehrer (tracyboehrer)
approved these changes
Apr 16, 2021
tracyboehrer (tracyboehrer)
pushed a commit
that referenced
this pull request
Apr 16, 2021
…cy areas. (#1167) * Implement TeamsSSOExchangeMiddleware * Fixes for Cosmos, OAuthPrompt, and TokenExchange
tracyboehrer (tracyboehrer)
added a commit
that referenced
this pull request
Apr 26, 2021
* Update main branch and readme.md version (#1153) * Added snapshot support to parent POM (#1157) * Corrected type and path of UserToken.exchangeToken (#1159) * Update CODE_OF_CONDUCT.md update to april 19th content * [SDK][Recognizers-Text] Update temporal folder with latest changes (#1164) * Update Datetime extractors * Update Datetime resources * Update Number resources * Update NumberWithUnit resources * Update NumberWithUnit extractors * Update NumberWithUnit parsers * Implement TeamsSSOExchangeMiddleware and fixes to associated dependency areas. (#1167) * Implement TeamsSSOExchangeMiddleware * Fixes for Cosmos, OAuthPrompt, and TokenExchange * [SDK][Recognizers-Text] Add Recognizer-Text unit tests into the temporal Recognizer-Text folder in bot-dialogs library (#1168) * Add timex-expression unit tests * Add Specs folder * Add datetime unit tests * Add sequence unit tests * Add number with unit unit tests * Add number unit tests * Add choice unit tests * Add text unit tests * Update bot-dialogs pom to use UTF-8 to execute unit tests correctly Co-authored-by: Martin Battaglino <martinbatta32@gmail.com> * Support for Recognizer tests on MacOS. (#1173) * Updated pom.xml to enable Jacoco output (#1175) * Add additional unit test coverage (#1185) * Activity Unit Tests * additional unit tests * Remove surefire entry from dialogs pom.xml * Update surefire entry in pom.xml * Additional tests and fixes. * Additional unit tests and fixes. * Additional tests * Update pom.xml for release version. * Fix surefire args Co-authored-by: tracyboehrer <tracyboehrer@users.noreply.github.com> Co-authored-by: Scott Gellock <scott.gellock@microsoft.com> Co-authored-by: Martin Battaglino <martinbatta32@gmail.com> Co-authored-by: Franco Alvarez <51216149+fran893@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1161
Description
Ported Code for TeamsSSOExchangeMiddleware
Specific Changes
Ported code for TeamsSSOExchangeMiddleware from the C# implementation. Also corrected issues with OAuthPrompt related to handling of TokenExchange, as well as CosmosDbPartitionedStorage issues which were causing a race condition in retrieving bot state.
Testing
TeamsSSO code was tested within the Teams Auth sample, along with the other changes made to Cosmos and OAuthPrompt.