This repository was archived by the owner on Dec 4, 2023. It is now read-only.
[Linter] Upgrade Checkstyle plugin to 3.1.2 supporting Checkstyle version up to 8.41 - #1226
Merged
tracyboehrer (tracyboehrer) merged 3 commits intoJun 9, 2021
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Martin Battaglino (Batta32)
requested review from
Lee Parrish (LeeParrishMSFT) and
tracyboehrer (tracyboehrer)
and removed request for
Lee Parrish (LeeParrishMSFT)
June 9, 2021 14:49
tracyboehrer (tracyboehrer)
approved these changes
Jun 9, 2021
Martin Battaglino (Batta32)
deleted the
external/feature/southworks/linter/update-version
branch
June 9, 2021 15:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1215
Description
The current Checkstyle rules cannot be consumed by the Checkstyle plugin greater or equal than 8.24. For this, we updated the checkstyle plugin integrated in the pom.xml from 3.1.0 to 3.1.2 (latest) which defaults to checkstyle 8.29.
With the update of the rules, we support up to the checkstyle version 8.41 inclusive, solving the breaking change mentioned in the checkstyle release 8.24.
Last but not least, the checkstyle version 8.42 has another breaking change which is not supported with this PR.
Specific Changes
Testing
mvn clean install passing correctly
