Align TranscriptLoggerMiddleware implementation with C# version - #141
Conversation
Sorry, something went wrong.
The TranscriptLoggerMiddleware works on the Emulator, but fails when run
on Azure Infrastructure. This is caused by the invalid modification of
the incoming Activity.
The modifications then create invalid data leading to this JSON fragment
for reply activities:
{
// ...
"recipient":{
"properties":{
"role":{}
},
"id":"8d51e790-8bd3-4450-af3d-1741838d1354",
"role":{}
},
// ...
}
The role properties should be set to a string, not an object. This
results in a
http 400 status from the bot framework:
{
"error": {
"code": "BadSyntax",
"message": "Invalid or missing Activity in request"
}
}
|
tracyboehrer (@tracyboehrer) this is an alternative implementation to #139 . The intention is to keep the change minimal, but still make it compatible with the azure backend. I had a look at the C# implementation and this is in my view the same approach as taken there. |
Sorry, something went wrong.
|
Matthias Bläsing (@matthiasblaesing) I compared to the Python impl, and your original technique of setting the Role on the From ChannelAccount appears to be correct as well. That version was taken from JavaScript. Python if activity:
if not activity.from_property.role:
activity.from_property.role = "user"
self.log_activity(transcript, copy.copy(activity))
JS if (context.activity) {
if (!context.activity.from.role) {
context.activity.from.role = "user";
}
this.logActivity(transcript, this.cloneActivity(context.activity));
}
This is all some fairly old code. My hunch is that "role" wasn't originally defined, and came in through the overflow "properties" member on ChannelAccount. Still a bug that Java was using an ObjectNode though. With that said, I'm having a conversation with the architects. The initial feedback was that a more recent strategy was not to mutate an incoming Activity. Though I would bet there are still places it's being done. I should hear back shortly. |
Sorry, something went wrong.
|
Closing in favor of original PR |
Sorry, something went wrong.
The TranscriptLoggerMiddleware works on the Emulator, but fails when run
on Azure Infrastructure. This is caused by the invalid modification of
the incoming Activity.
The modifications then create invalid data leading to this JSON fragment
for reply activities:
The role properties should be set to a string, not an object. This
results in a
http 400 status from the bot framework:
{ "error": { "code": "BadSyntax", "message": "Invalid or missing Activity in request" } }