This repository was archived by the owner on Dec 4, 2023. It is now read-only.
Remove the unnecessary filtering, the bot itself has been filtered out already in ActivityHandler.java - #453
Merged
tracyboehrer (tracyboehrer) merged 1 commit intoApr 17, 2020
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…in ActivityHandler.java
Copy link
Copy Markdown
Member
|
Fredrik (Zhiyu) Luo (@fredrikluo) Thanks! I'll look into the build issue. I don't believe it's related to your PR. |
Sorry, something went wrong.
tracyboehrer (tracyboehrer)
approved these changes
Apr 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bot itself has been filtered in activityHandler.java see:
botbuilder-java/libraries/bot-builder/src/main/java/com/microsoft/bot/builder/ActivityHandler.java
Line 142 in 45ad1e0
Suggest removing this line from the sample since it's quite confusing, it could lead people to think onMembersAdded will be called when the bot is added to the channel, which is reasonable since bot service does send out MemebersAdd when a bot is added.
This, of course, will never happen.