This repository was archived by the owner on Dec 4, 2023. It is now read-only.
[Samples] Add 17.multilingual-bot sample - #898
Merged
tracyboehrer (tracyboehrer) merged 13 commits intoJan 13, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
* Fix test errors * Fix error in Middleware * Apply feedback * Add missing this
Martin Battaglino (Batta32)
requested review from
Lee Parrish (LeeParrishMSFT) and
tracyboehrer (tracyboehrer)
January 8, 2021 20:44
tracyboehrer (tracyboehrer)
suggested changes
Jan 12, 2021
tracyboehrer (tracyboehrer)
marked this pull request as ready for review
January 13, 2021 14:56
tracyboehrer (tracyboehrer)
approved these changes
Jan 13, 2021
Lee Parrish (LeeParrishMSFT)
approved these changes
Jan 13, 2021
* Fix translation error * Add component notation in MultiLingualBot * Add notation to ignore unknown properties * Fix error when trasnlationKey is empty
Copy link
Copy Markdown
Contributor
Author
|
tracyboehrer (@tracyboehrer) & Lee Parrish (@LeeParrishMSFT) - the sample is correctly working and the PR is ready to be merged! |
Sorry, something went wrong.
Martin Battaglino (Batta32)
deleted the
feature/southworks/sample/17-multilingual-bot/base
branch
January 13, 2021 18:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
2 more reviewersAssignees
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #868
Description
We are adding the sample 17.multilingual-bot in Java having into account the C# 17.multilingual-bot present in BotBuilder-Samples repository.
Specific Changes
Testing
We are currently testing the migrated sample. As soon as it's validated, it will be ready to be merged.
Current behavior of the Java migrated sample
