This repository was archived by the owner on Jan 5, 2026. It is now read-only.
Avoid exceptions for request without Content-Type header - #1881
Closed
Ivo Pisarovic (ivopisarovic) wants to merge 1 commit into
Closed
Avoid exceptions for request without Content-Type header#1881Ivo Pisarovic (ivopisarovic) wants to merge 1 commit into
Ivo Pisarovic (ivopisarovic) wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Fix: some requests may not have content-type header.
Ivo Pisarovic (ivopisarovic)
requested review from
a team and
Gary Pretty (garypretty)
as code owners
January 5, 2022 13:55
Ivo Pisarovic (ivopisarovic)
requested review from
Axel Suárez (axelsrz)
and removed request for
a team
January 5, 2022 13:55
Copy link
Copy Markdown
Member
|
We can't make changes to previous release branches. Is this still applicable to main? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
I’m afk now. I will look at it in 2 weeks. |
Sorry, something went wrong.
Ivo Pisarovic (ivopisarovic)
changed the base branch from
releases/4.14
to
main
August 8, 2022 12:43
Ivo Pisarovic (ivopisarovic)
changed the base branch from
main
to
releases/4.14
August 8, 2022 12:44
Copy link
Copy Markdown
Contributor
Author
|
tracyboehrer (@tracyboehrer) I looked at it an the affected files has not been changed since then. Hence, the same change applies also to main. I am closing this and opening a new PR into main: #1961 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If a non-bot request comes to the server, it raised an exception because some request may not have content-type header.
Specific Changes
Testing