This repository was archived by the owner on Jan 15, 2025. It is now read-only.
Fix a regression on multiturn extraction functionality of qna url or file import api - #1042
Merged
Fei Chen (feich-ms) merged 2 commits intoOct 30, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Fei Chen (feich-ms)
requested a review
from Emilio Munoz (munozemilio)
as a code owner
October 30, 2020 02:14
Dong Lei (boydc2014)
approved these changes
Oct 30, 2020
Copy link
Copy Markdown
Contributor
|
Can we add some test case to avoid regression like this? |
Sorry, something went wrong.
Fei Chen (feich-ms)
added a commit
that referenced
this pull request
Oct 30, 2020
…file import api (#1042) * fix regression on file and url import api * add unit tests for multiturn extraction"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Composer team reported a regression issue microsoft/BotFramework-Composer#4590 on the multirun extraction functionality of url and file import api in bf-lu library. This was caused by a bad merge before. To avoid such regression in the future, more specific tests are added in this PR.