FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

cherry pick changes from main by tsuwandy · Pull Request #1194 · microsoft/botframework-cli · GitHub

This repository was archived by the owner on Jan 15, 2025. It is now read-only.
/ botframework-cli Public archive

cherry pick changes from main - #1194

Closed
Tien Suwandy (tsuwandy) wants to merge 18 commits into
4.13from
tiens-4.13
ConversationCommits (18)ChecksFiles changed
Closed

cherry pick changes from main#1194
Tien Suwandy (tsuwandy) wants to merge 18 commits into
4.13from
tiens-4.13

Conversation

Tien Suwandy (tsuwandy) commented Apr 15, 2021

Copy link
Copy Markdown
Contributor

Fixes #1193

  1. Support composer client using proxy
  2. Fixed bug in bf orchestrator:add

Emilio Munoz (munozemilio) and others added 17 commits April 1, 2021 17:42
Bumping version for next release (#1174)
7e5fa93
Fix for issue 1177 (#1178)
74baacc
Update add.ts
2648f2c
Replace node fetch to axios to enable proxy in luis and qnamaker build (
6745788 
#1182)

* replace node fetch and luis client to axios to enable proxy in luis and qnamaker build

* fix tests
Fixes #1184 (#1185)
393d33d 
Treats files with identical content as not being duplicated.  This is because
nuget likes to copy the same files in multiple places.

Co-authored-by: Chris McConnell <chrimc>
fix axios bug to support https proxy (#1186)
1a5070e
Merge branch 'main' into tiens-patch-1
6a14e1e
node-fetch-with-proxy changes
1758a7c
node-fetch -> node-fetch-with-proxy
33dac07
Switch to axios to support proxy server when merging. (#1190)
161c029 
* Switch to axios to support proxy server when merging.
Normalize sorting to reduce variation.

* modify https proxy setting

* refactor

* fix lint

* fix lint

Co-authored-by: Chris McConnell <chrimc>
Co-authored-by: cosmicshuai <shuai_uf@outlook.com>
Merge branch 'main' into tiens-patch-1
92c6186
fix lint
4a13a96
fix for orchestrator:add -t luis/qna
6ae3ee2
Merge branch 'tiens-patch-1' into 4.13
bbe9e29
Revert "Merge branch 'tiens-patch-1' into 4.13"
0b33dd5 
This reverts commit bbe9e29, reversing
changes made to bf75952.
cherry pick changes from main
805ce88
Update pnpm-lock.yaml
9a4e061

daveta commented Apr 15, 2021

Copy link
Copy Markdown
Contributor

Getting chatdown build errors.. Fei Chen (@feich-ms) does this look familiar?
src/commands/chatdown/convert.ts(159,75): error TS2794: Expected 1 arguments, but got 0. Did you forget to include 'void' in your type argument to 'Promise'?

Fei Chen (feich-ms) commented Apr 15, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Getting chatdown build errors.. Fei Chen (@feich-ms) does this look familiar?
src/commands/chatdown/convert.ts(159,75): error TS2794: Expected 1 arguments, but got 0. Did you forget to include 'void' in your type argument to 'Promise'?

I ever ran into this when I rush build locally, but haven't seen this in online CI validation. I can repro this error after I run rush update and then rush build. I think this may be caused by the upgrade of typescript version, fix should be easy https://stackoverflow.com/questions/65354965/error-ts2794-expected-1-arguments-but-got-0-did-you-forget-to-include-void

daveta commented Apr 15, 2021

Copy link
Copy Markdown
Contributor

This is referencing a package with security problems.

daveta closed this Apr 15, 2021
Tien Suwandy (tsuwandy) deleted the tiens-4.13 branch April 15, 2021 16:50
This was referenced Dec 31, 2021
Open
Open
Open
Open
Snyk bot (snyk-bot) mentioned this pull request Aug 19, 2022
Open
Open
Snyk bot (snyk-bot) mentioned this pull request Aug 19, 2022
Open
This was referenced Aug 19, 2022
Open
Open
This was referenced Aug 19, 2022
Open
Open
This was referenced Jun 21, 2023
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Nov 30, 2023
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Chris Mullins (cleemullins) Awaiting requested review from cleemullins
Josh Gummersall (joshgummersall) Awaiting requested review from joshgummersall
Emilio Munoz (munozemilio) Awaiting requested review from munozemilio

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL